test: Wait for pod event to show up #69300
Merged
+28
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
Member
|
adding a wait makes total sense here. /lgtm |
k8s-ci-robot
added
the
lgtm
Member
|
/assign @smarterclayton |
We are seeing flakes where pod event isn't yet visible when we check for it leading to test failure. Signed-off-by: Mrunal Patel <[email protected]>
mrunalp
force-pushed
the
subpath_test_wait_for_event
branch
from
00c5fde to
c771de1
Compare
k8s-ci-robot
removed
the
lgtm
Contributor
|
/approve e2e tests should wait for events and not assume they happen immediately |
k8s-ci-robot
added
the
approved
Member
|
/kind flake @mrunalp can you also link to the flake issue this resolves that we hit in origin ci |
k8s-ci-robot
added
kind/flake
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, mrunalp, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing flakes where pod event isn't yet visible when
we check for it leading to test failure.
cc: @derekwaynecarr @smarterclayton @runcom
Signed-off-by: Mrunal Patel [email protected]
What this PR does / why we need it:
Adds a wait loop for a pod event to show up in subpath test.