Skip to content

remove flag: insecure-experimental-approve-all-kubelet-csrs-for-group #69209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Oct 26, 2018
Merged

remove flag: insecure-experimental-approve-all-kubelet-csrs-for-group #69209

k8s-ci-robot merged 1 commit into from
Oct 26, 2018

Conversation

@Pingan2017
Copy link
Contributor

@Pingan2017 Pingan2017 commented Sep 28, 2018 •
edited
Loading

What this PR does / why we need it:
this flag is deprecated in 1.7, remove it.
/kind cleanup

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Remove kube-controller-manager flag '--insecure-experimental-approve-all-kubelet-csrs-for-group'(deprecated in v1.7)

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 28, 2018
@Pingan2017
Copy link
Contributor Author

Pingan2017 commented Sep 28, 2018

/assign @deads2k

@wgliang
Copy link
Contributor

wgliang commented Sep 28, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 28, 2018
@Pingan2017
Copy link
Contributor Author

Pingan2017 commented Sep 28, 2018

/test pull-kubernetes-integration
/test pull-kubernetes-e2e-kops-aws

@Pingan2017
Copy link
Contributor Author

Pingan2017 commented Oct 8, 2018

ping @kubernetes/sig-api-machinery-pr-reviews
Could someone take a look? Thanks!

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 8, 2018

@Pingan2017: Reiterating the mentions to trigger a notification:
@kubernetes/sig-api-machinery-pr-reviews

Details

In response to this:

ping @kubernetes/sig-api-machinery-pr-reviews
Could someone take a look? Thanks!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Pingan2017
Copy link
Contributor Author

Pingan2017 commented Oct 13, 2018

ping @sttts @deads2k Could take a look? Thank u!

@Pingan2017
Copy link
Contributor Author

Pingan2017 commented Oct 13, 2018

Also cc @lavalamp @ingvagabund

@liggitt
Copy link
Member

liggitt commented Oct 13, 2018

/lgtm
/approve

Please add a release note description

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 13, 2018
@Pingan2017
Copy link
Contributor Author

Pingan2017 commented Oct 15, 2018

ping @deads2k Could you take a look? Thank u

@liggitt
Copy link
Member

liggitt commented Oct 25, 2018

/assign @mikedanese
for approval

@mikedanese
Copy link
Member

mikedanese commented Oct 25, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 25, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mikedanese, Pingan2017

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2018
@k8s-ci-robot k8s-ci-robot merged commit 0ba00ec into kubernetes:master Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

@sttts sttts Awaiting requested review from sttts

Assignees

@liggitt liggitt

@mikedanese mikedanese

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Pingan2017 @wgliang @k8s-ci-robot @liggitt @mikedanese @deads2k