Skip to content

Adding myself as OWNER for vSphere Cloud Provider. #69187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 2 commits into from
Oct 11, 2018
Merged

Adding myself as OWNER for vSphere Cloud Provider. #69187

k8s-ci-robot merged 2 commits into from
Oct 11, 2018
+8 −4

Conversation

@SandeepPissay
Copy link
Contributor

@SandeepPissay SandeepPissay commented Sep 27, 2018 •
edited
Loading

Adding myself and few folks from VMware as owner of vSphere volume provisioner/vSphere cloud provider. Also removing some users as they no longer work on vSphere volume provisioner/vSphere cloud provider.

Updating OWNERS list for vSphere Cloud Provider.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 27, 2018
@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 27, 2018
@SandeepPissay
Copy link
Contributor Author

SandeepPissay commented Sep 27, 2018

@abrarshivani @divyenpatel can you guys approve this PR? Thanks.

@SandeepPissay
Copy link
Contributor Author

SandeepPissay commented Sep 27, 2018

/assign @BaluDontu

@SandeepPissay
Copy link
Contributor Author

SandeepPissay commented Sep 27, 2018

/assign @abrarshivani

@BaluDontu
Copy link
Contributor

BaluDontu commented Sep 27, 2018

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2018
@divyenpatel
Copy link
Member

divyenpatel commented Sep 28, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 28, 2018
@divyenpatel
Copy link
Member

divyenpatel commented Sep 28, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2018
@abrarshivani
Copy link
Contributor

abrarshivani commented Sep 28, 2018

/approve

@SandeepPissay
Copy link
Contributor Author

SandeepPissay commented Oct 9, 2018

/retest

@SandeepPissay
Copy link
Contributor Author

SandeepPissay commented Oct 9, 2018

@saad-ali Can you approve this?

saad-ali
saad-ali approved these changes Oct 9, 2018
View reviewed changes
Copy link
Member

@saad-ali saad-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 9, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrarshivani, BaluDontu, saad-ali, SandeepPissay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 9, 2018
@SandeepPissay
Copy link
Contributor Author

SandeepPissay commented Oct 9, 2018 •
edited
Loading

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 9, 2018
@SandeepPissay
Copy link
Contributor Author

SandeepPissay commented Oct 9, 2018

/retest

@fejta-bot
Copy link

fejta-bot commented Oct 10, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

6 similar comments
@fejta-bot
Copy link

fejta-bot commented Oct 10, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

fejta-bot commented Oct 10, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

fejta-bot commented Oct 10, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

fejta-bot commented Oct 10, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

fejta-bot commented Oct 10, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

fejta-bot commented Oct 10, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 43d61f4 into kubernetes:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsafrane jsafrane Awaiting requested review from jsafrane

2 more reviewers

@saad-ali saad-ali saad-ali approved these changes

@divyenpatel divyenpatel divyenpatel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@abrarshivani abrarshivani

@saad-ali saad-ali

@BaluDontu BaluDontu

@divyenpatel divyenpatel

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@SandeepPissay @BaluDontu @divyenpatel @abrarshivani @k8s-ci-robot @fejta-bot @saad-ali