Skip to content

PDB checks should not be done for terminal pods while evicting #68892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Sep 27, 2018
Merged

PDB checks should not be done for terminal pods while evicting #68892

k8s-ci-robot merged 1 commit into from
Sep 27, 2018
+99 −0

Conversation

@ravisantoshgudimetla
Copy link
Contributor

@ravisantoshgudimetla ravisantoshgudimetla commented Sep 20, 2018

Signed-off-by: ravisantoshgudimetla [email protected]

What this PR does / why we need it:
As of now, while evicting terminal pods, we are checking pod disruption budgets for them where as we don't need to check pdbs for them as they already have caused disruption.
/cc @derekwaynecarr

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Pod disruption budgets shouldn't be checked for terminal pods while evicting

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 20, 2018
@ravisantoshgudimetla
Copy link
Contributor Author

ravisantoshgudimetla commented Sep 20, 2018 •
edited
Loading

/sig scheduling
/sig api-server

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Sep 20, 2018
@ravisantoshgudimetla
Copy link
Contributor Author

ravisantoshgudimetla commented Sep 20, 2018

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 20, 2018
@ravisantoshgudimetla
Copy link
Contributor Author

ravisantoshgudimetla commented Sep 20, 2018

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Sep 20, 2018
@derekwaynecarr
Copy link
Member

derekwaynecarr commented Sep 20, 2018

@ravisantoshgudimetla thank you for following up on this!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2018
@deads2k
Copy link
Contributor

deads2k commented Sep 20, 2018

/approve

This can prevent draining, but I don't think it is a regression (@ravisantoshgudimetla correct me if I'm mistaken). We should backport for 1.12.1.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2018
bsalamat
bsalamat approved these changes Sep 20, 2018
View reviewed changes
Copy link
Member

@bsalamat bsalamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this change. We must also ensure that the caller which requests the eviction checks the status of the pod and not request it for terminated pods.

/lgtm

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 20, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, deads2k, derekwaynecarr, ravisantoshgudimetla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3d2fcf4 into kubernetes:master Sep 27, 2018
@ravisantoshgudimetla ravisantoshgudimetla deleted the fix-pdb branch September 27, 2018 15:29
@ravisantoshgudimetla ravisantoshgudimetla mentioned this pull request Oct 4, 2018
Merged
k8s-ci-robot referenced this pull request Oct 5, 2018
@k8s-ci-robot
Merge pull request #69378 from ravisantoshgudimetla/automated-cherry-…
3bf9523 
…pick-of-#68892-upstream-release-1.12

PDB checks should not be done for terminal pods while evicting
@liggitt liggitt mentioned this pull request Sep 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

1 more reviewer

@bsalamat bsalamat bsalamat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@derekwaynecarr derekwaynecarr

@bsalamat bsalamat

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ravisantoshgudimetla @derekwaynecarr @deads2k @k8s-ci-robot @bsalamat