Skip to content

Optimizes calculating stats when only CPU and Memory stats are returned from Kubelet stats/summary http endpoint. #68841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 2 commits into from
Oct 18, 2018
Merged

Optimizes calculating stats when only CPU and Memory stats are returned from Kubelet stats/summary http endpoint. #68841

k8s-ci-robot merged 2 commits into from
Oct 18, 2018

Conversation

@krzysztof-jastrzebski
Copy link
Contributor

@krzysztof-jastrzebski krzysztof-jastrzebski commented Sep 19, 2018 •
edited
Loading

What this PR does / why we need it:
PR optimizes calculating stats when only CPU and Memory stats are returned from Kubelet stats/summary http endpoint. After this PR is submitted only CPU and memory stats will be calculated instead of calculating all stats and removing them from response.

Release note:

Optimizes calculating stats when only CPU and Memory stats are returned from Kubelet stats/summary http endpoint.

@krzysztof-jastrzebski
Add "only_cpu_and_memory" GET parameter to /stats/summary http handle…
138a3c7 
…r in kubelet. If parameter is true then only cpu and memory will be present in response. The parameter will be used by Metric Server to avoid sending/decoding unneeded data.
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 19, 2018
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 19, 2018
@krzysztof-jastrzebski krzysztof-jastrzebski mentioned this pull request Sep 19, 2018
Merged
@losipiuk
Copy link
Contributor

losipiuk commented Sep 20, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 20, 2018
@krzysztof-jastrzebski
Process only CPU and memory stats when Kubelete stats API is called with
3b21995 
only_cpu_and_memory parameter. Before all stats were processed and
removed before returning.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 20, 2018
@krzysztof-jastrzebski krzysztof-jastrzebski changed the title WIP: Process only CPU and memory stats when Kubelete stats API is called. Optimizes calculating stats when only CPU and Memory stats are returned from Kubelet stats/summary http endpoint. Sep 20, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2018
@krzysztof-jastrzebski
Copy link
Contributor Author

krzysztof-jastrzebski commented Sep 20, 2018

/assign mwielgus
/assign yujuhong

@yujuhong
Copy link
Contributor

yujuhong commented Sep 26, 2018

/assign @dashpole

@dashpole is working on core metrics and probably have more opinions on this part of the code.

@dashpole
Copy link
Contributor

dashpole commented Sep 26, 2018

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 26, 2018
@dashpole
Copy link
Contributor

dashpole commented Sep 26, 2018

/lgtm
This is basically a copy of the existing Get() function stack, but with the unused parts removed. It copies a lot of code, but given #67829 (comment), I think this is a decent approach.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2018
@krzysztof-jastrzebski
Copy link
Contributor Author

krzysztof-jastrzebski commented Oct 18, 2018

Could you give approve?

@yujuhong
Copy link
Contributor

yujuhong commented Oct 18, 2018

/approve
based on @dashpole's lgtm

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 18, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzysztof-jastrzebski, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2018
@fejta-bot
Copy link

fejta-bot commented Oct 18, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 4339a70 into kubernetes:master Oct 18, 2018
@mengjiao-liu mengjiao-liu mentioned this pull request Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vishh vishh Awaiting requested review from vishh

@yifan-gu yifan-gu Awaiting requested review from yifan-gu

Assignees

@dashpole dashpole

@yujuhong yujuhong

@mwielgus mwielgus

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@krzysztof-jastrzebski @losipiuk @yujuhong @dashpole @k8s-ci-robot @fejta-bot @mwielgus