Skip to content

Conversation

@x13n
Copy link
Member

@x13n x13n commented Sep 19, 2018

What this PR does / why we need it:
Version 0.5 reduces the log spam.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Special notes for your reviewer:

Release note:

Reduced excessive logging from fluentd-gcp-scaler.

/assign @loburm

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 19, 2018
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 19, 2018
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/gcp approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 19, 2018
@loburm
Copy link
Contributor

loburm commented Sep 21, 2018

You have one small typo in release notes: fluentd-gcp-scaler
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: loburm, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@x13n
Copy link
Member Author

x13n commented Sep 21, 2018

Thanks! Updated.

@nikhita
Copy link
Member

nikhita commented Sep 25, 2018

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 25, 2018
@k8s-ci-robot k8s-ci-robot merged commit b113309 into kubernetes:master Sep 27, 2018
k8s-ci-robot added a commit that referenced this pull request Oct 3, 2018
…pstream-release-1.12

Automated cherry pick of #68837: Bump version of fluentd-gcp-scaler
k8s-ci-robot added a commit that referenced this pull request Oct 4, 2018
…pstream-release-1.11

Automated cherry pick of #68837: Bump version of fluentd-gcp-scaler
k8s-ci-robot added a commit that referenced this pull request Oct 10, 2018
…pstream-release-1.10

Automated cherry pick of #68837: Bump version of fluentd-gcp-scaler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants