Skip to content

Extract cpu requests to separate env variables. #68823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Oct 2, 2018
Merged

Extract cpu requests to separate env variables. #68823

k8s-ci-robot merged 1 commit into from
Oct 2, 2018
+8 −2

Conversation

@loburm
Copy link
Contributor

@loburm loburm commented Sep 19, 2018 •
edited
Loading

This PR doesn't change current behavior of cluster, but introduces functionality that allow to control cpu requests of kube-controller-manager and kube-scheduler via environment variables.

[GCP] Added env variables to control CPU requests of kube-controller-manager and kube-scheduler.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 19, 2018
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 19, 2018
@loburm loburm mentioned this pull request Sep 19, 2018
Closed
@wojtek-t wojtek-t self-assigned this Sep 19, 2018
@wojtek-t
Copy link
Member

wojtek-t commented Sep 19, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 19, 2018
@loburm loburm mentioned this pull request Sep 19, 2018
Merged
@loburm
Copy link
Contributor Author

loburm commented Sep 19, 2018

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2018
k8s-ci-robot added a commit that referenced this pull request Sep 24, 2018
@k8s-ci-robot
Merge pull request #68825 from loburm/automated-cherry-pick-of-#68823…
aafca73 
…-upstream-release-1.11

Automated cherry pick of #68823: Extract cpu requests to separate env variables.
@nikhita
Copy link
Member

nikhita commented Sep 25, 2018

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 25, 2018
@wojtek-t
Copy link
Member

wojtek-t commented Oct 1, 2018

@loburm please rebase

@loburm loburm force-pushed the use_env_var_master branch from c3efb1d to 5a118f9 Compare October 2, 2018 05:55
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 2, 2018
@loburm
Copy link
Contributor Author

loburm commented Oct 2, 2018

@wojtek-t done, PTAL.

@loburm loburm mentioned this pull request Oct 2, 2018
Merged
@wojtek-t
Copy link
Member

wojtek-t commented Oct 2, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2018
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 2, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: loburm, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7c40095 into kubernetes:master Oct 2, 2018
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 3, 2018
k8s-ci-robot added a commit that referenced this pull request Oct 4, 2018
@k8s-ci-robot
Merge pull request #69320 from loburm/automated-cherry-pick-of-#68823…
618359d 
…-upstream-release-1.12

Automated cherry pick of #68823: Extract cpu requests to separate env variables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmarek gmarek Awaiting requested review from gmarek

@jingax10 jingax10 Awaiting requested review from jingax10

Assignees

@wojtek-t wojtek-t

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@loburm @wojtek-t @nikhita @k8s-ci-robot