Skip to content

Bump metrics-server to v0.3.1 #68746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Sep 18, 2018
Merged

Bump metrics-server to v0.3.1 #68746

k8s-ci-robot merged 1 commit into from
Sep 18, 2018
+6 −6

Conversation

@DirectXMan12
Copy link
Contributor

@DirectXMan12 DirectXMan12 commented Sep 17, 2018

This fixes an issue with overly aggressive discardings of node data sets
when a single pod is missing data.

Fixes #68383

Release note:

Update metrics-server to v0.3.1

@DirectXMan12
Bump metrics-server to v0.3.1
13d59fd 
This fixes an issue with overly aggressive discardings of node data sets
when a single pod is missing data.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 17, 2018
@DirectXMan12
Copy link
Contributor Author

DirectXMan12 commented Sep 17, 2018

cc @tpepper

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 17, 2018
@k8s-ci-robot k8s-ci-robot requested a review from piosz September 17, 2018 15:36
@DirectXMan12
Copy link
Contributor Author

DirectXMan12 commented Sep 17, 2018

@kubernetes/sig-instrumentation-bugs @kubernetes/sig-autoscaling-bugs

@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. kind/bug Categorizes issue or PR as related to a bug. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 17, 2018
@tpepper
Copy link

tpepper commented Sep 17, 2018

We're looking for this ASAP to get test results ahead of a decision to delay k8s 1.12 release.

@brancz
Copy link
Member

brancz commented Sep 17, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2018
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 17, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, DirectXMan12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot
Copy link

fejta-bot commented Sep 17, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@tpepper
Copy link

tpepper commented Sep 17, 2018

/priority critical-urgent
/retest

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Sep 17, 2018
@tpepper
Copy link

tpepper commented Sep 17, 2018

/retest

@tpepper
Copy link

tpepper commented Sep 17, 2018

(for anybody following along pull-kubernetes-e2e-gke has a known issue making it HIGHLY flakey, with a fix coming in GKE later today)

@tpepper
Copy link

tpepper commented Sep 18, 2018

/retest

1 similar comment
@tpepper
Copy link

tpepper commented Sep 18, 2018

/retest

@fejta-bot
Copy link

fejta-bot commented Sep 18, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@DirectXMan12
Copy link
Contributor Author

DirectXMan12 commented Sep 18, 2018

Tests look good. Looks like unrelated GKE failures

@fejta-bot
Copy link

fejta-bot commented Sep 18, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@tpepper
Copy link

tpepper commented Sep 18, 2018

/milestone v1.12

@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Sep 18, 2018
@tpepper
Copy link

tpepper commented Sep 18, 2018

/retest

1 similar comment
@tpepper
Copy link

tpepper commented Sep 18, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit be74187 into kubernetes:master Sep 18, 2018
@DirectXMan12 DirectXMan12 deleted the bug/metrics-server-v0.3.1 branch September 19, 2018 08:32
rfranzke added a commit to gardener/gardener that referenced this pull request Sep 19, 2018
@rfranzke
Bump metrics-server to v0.3.1
b915942 
See kubernetes/kubernetes#68746
richardyuwen pushed a commit to richardyuwen/gardener that referenced this pull request Mar 26, 2019
@rfranzke
Bump metrics-server to v0.3.1
55e1086 
See kubernetes/kubernetes#68746
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@piosz piosz Awaiting requested review from piosz

Assignees

@brancz brancz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.12

Development

Successfully merging this pull request may close these issues.

HPA test is flaky

5 participants

@DirectXMan12 @tpepper @brancz @k8s-ci-robot @fejta-bot