Get public IP for Azure vmss nodes #68498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
Member
Author
|
cc @kkmsft |
Member
Author
|
/assign @andyzhangx |
andyzhangx
reviewed
Sep 20, 2018
Member
There was a problem hiding this comment.
are you going to remove this comment:
TODO(feiskyer): Azure vmss doesn't support associating a public IP to single virtual machine yet,
Member
Author
There was a problem hiding this comment.
Good catch. The comment should be removed.
This is required for getting public IP when --public-ip-per-vm (publicIpAddressConfiguration) is enabled for vmss.
Member
Author
|
@andyzhangx comments removed. PTAL |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Sep 26, 2018
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 28, 2018
…98-upstream-release-1.12 Automated cherry pick of #68498: Get public IP for Azure vmss nodes
k8s-ci-robot
added a commit
that referenced
this pull request
Oct 2, 2018
…98-upstream-release-1.10 Automated cherry pick of #68498: Get public IP for Azure vmss nodes
k8s-ci-robot
added a commit
that referenced
this pull request
Oct 4, 2018
…98-upstream-release-1.11 Automated cherry pick of #68498: Get public IP for Azure vmss nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note:
/kind bug
/sig azure