Skip to content

Conversation

@wgliang
Copy link
Contributor

@wgliang wgliang commented Sep 7, 2018

What this PR does / why we need it:
Chaos client isn’t used anywhere, and we need to remove it soon.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #68337

Special notes for your reviewer:
@smarterclayton

Release note:

Remove unused chaosclient.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 7, 2018
@wgliang
Copy link
Contributor Author

wgliang commented Sep 7, 2018

/area client-libraries

@wgliang wgliang force-pushed the feature/remove-chaosclien branch from 5c1f627 to 095f905 Compare September 7, 2018 13:43
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 7, 2018
@smarterclayton
Copy link
Contributor

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2018
@wgliang wgliang force-pushed the feature/remove-chaosclien branch from 095f905 to a7df519 Compare September 7, 2018 14:32
@yue9944882
Copy link
Member

/kind cleanup
/lgtm

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 7, 2018
@wgliang
Copy link
Contributor Author

wgliang commented Sep 12, 2018

@smarterclayton
Will we merge in v.1.12?

@smarterclayton
Copy link
Contributor

smarterclayton commented Sep 12, 2018 via email

@wgliang
Copy link
Contributor Author

wgliang commented Sep 12, 2018

/test pull-kubernetes-local-e2e-containerized

@wgliang wgliang force-pushed the feature/remove-chaosclien branch from a7df519 to 1eceb1d Compare September 26, 2018 00:43
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2018
@wgliang
Copy link
Contributor Author

wgliang commented Sep 26, 2018

update for conflicts.

@smarterclayton PTAL.

@wgliang
Copy link
Contributor Author

wgliang commented Sep 26, 2018

/test pull-kubernetes-integration

@liggitt
Copy link
Member

liggitt commented Oct 3, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, smarterclayton, wgliang, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f149d2a into kubernetes:master Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/client-libraries area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Infinite recursive call

5 participants