Skip to content

Update default etcd server to 3.2.24 for kubernetes 1.12 #68318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-github-robot merged 1 commit into from
Sep 7, 2018
Merged

Update default etcd server to 3.2.24 for kubernetes 1.12 #68318

k8s-github-robot merged 1 commit into from
Sep 7, 2018

Conversation

@timothysc
Copy link
Contributor

@timothysc timothysc commented Sep 6, 2018

What this PR does / why we need it:
Update default etcd server to 3.2.24 for kubernetes 1.12

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #68147

Special notes for your reviewer:
NONE

Release note:

Update default etcd server to 3.2.24 for kubernetes 1.12

/assign @wojtek-t @jpbetz @dims
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews @gyuho

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 6, 2018
@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Sep 6, 2018
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 6, 2018

@timothysc: GitHub didn't allow me to request PR reviews from the following users: gyuho.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

What this PR does / why we need it:
Update default etcd server to 3.2.24 for kubernetes 1.12

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #68147

Special notes for your reviewer:
NONE

Release note:

Update default etcd server to 3.2.24 for kubernetes 1.12

/assign @wojtek-t @jpbetz @dims
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews @gyuho

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/kubeadm sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 6, 2018
@timothysc timothysc added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 6, 2018
@timothysc timothysc added this to the v1.12 milestone Sep 6, 2018
@timothysc
Copy link
Contributor Author

timothysc commented Sep 6, 2018

/cc @liggitt

@k8s-ci-robot k8s-ci-robot requested a review from liggitt September 6, 2018 03:31
wojtek-t
wojtek-t reviewed Sep 6, 2018
View reviewed changes
test/e2e/framework/nodes_util.go Outdated
Copy link
Member

@wojtek-t wojtek-t Sep 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also modify test/kubemark/start-kubemark.sh

Copy link
Contributor Author

@timothysc timothysc Sep 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, plus I found one other test that needed an update too.

luxas
luxas approved these changes Sep 6, 2018
View reviewed changes
Copy link
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dims
Copy link
Member

dims commented Sep 6, 2018

i cross checked the changes in this PR with what i had from earlier and it looks good except for the one spot that @wojtek-t mentioned already in test/kubemark/start-kubemark.sh

# Etcd related variables.
ETCD_IMAGE="${ETCD_IMAGE:-3.2.18-0}"
ETCD_VERSION="${ETCD_VERSION:-}"

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 6, 2018
@timothysc
Copy link
Contributor Author

timothysc commented Sep 6, 2018

@wojtek-t PTAL.

@wojtek-t
Copy link
Member

wojtek-t commented Sep 6, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 6, 2018
@dims
Copy link
Member

dims commented Sep 6, 2018

+1 from me

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2018
@timothysc
Copy link
Contributor Author

timothysc commented Sep 6, 2018

/test pull-kubernetes-e2e-gke
/test pull-kubernetes-verify
/test pull-kubernetes-e2e-kops-aws

@sttts
Copy link
Contributor

sttts commented Sep 7, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2018
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 7, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts, timothysc, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

k8s-github-robot commented Sep 7, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

k8s-github-robot commented Sep 7, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

@k8s-github-robot k8s-github-robot merged commit 3617462 into kubernetes:master Sep 7, 2018
@dims dims mentioned this pull request Sep 19, 2018
Merged
@ixdy ixdy mentioned this pull request Sep 28, 2018
Merged
@jpbetz jpbetz mentioned this pull request Nov 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wojtek-t wojtek-t wojtek-t left review comments

@liggitt liggitt Awaiting requested review from liggitt

+1 more reviewer

@luxas luxas luxas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dims dims

@jpbetz jpbetz

@sttts sttts

@wojtek-t wojtek-t

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.12

Development

Successfully merging this pull request may close these issues.

8 participants

@timothysc @k8s-ci-robot @dims @wojtek-t @sttts @k8s-github-robot @luxas @jpbetz