Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide Flex volume metrics if the plugin supports. #67508

Merged
merged 1 commit into from
Sep 25, 2018
Merged

Provide Flex volume metrics if the plugin supports. #67508

merged 1 commit into from
Sep 25, 2018
+33 −12

Conversation

brahmaroutu
Copy link
Contributor

What this PR does / why we need it:
This PR enables metrics for Flex Drivers if the driver has the capability. By default metrics are not enabled on the driver but when the capability 'supportsMetrics' is set to true then this PR will allow to configure a fs stat metrics plugin to run metrics on the flex plugin.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #67400

Special notes for your reviewer:

Release note:

Flex drivers by default do not produce metrics. Flex plugins can enable metrics collection by setting  the capability 'supportsMetrics' to true. Make sure the file system can support fs stat to produce metrics in this case.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 16, 2018
@neolit123
Copy link
Member

/sig storage
/ok-to-test

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 16, 2018
@brahmaroutu
Copy link
Contributor Author

/retest

1 similar comment
@brahmaroutu
Copy link
Contributor Author

/retest

@gnufied
Copy link
Member

gnufied commented Aug 23, 2018

/assign @chakri-nelluri @saad-ali

@gnufied
Copy link
Member

gnufied commented Aug 28, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 28, 2018
@gnufied
Copy link
Member

gnufied commented Aug 28, 2018

I am just going to place temporary hold on the PR so as @chakri-nelluri has a chance to do a final review as well.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2018
@chakri-nelluri
Copy link
Contributor

Thanks @gnufied.
/LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brahmaroutu, chakri-nelluri, gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gnufied
Copy link
Member

gnufied commented Aug 28, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2018
@brahmaroutu
Copy link
Contributor Author

/retest

@brahmaroutu brahmaroutu mentioned this pull request Aug 29, 2018
Closed
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@brahmaroutu
Copy link
Contributor Author

@saad-ali @gnufied can we please prioritize to merge this PR along with tests under 68018. I believe Milestone is not set.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@chakri-nelluri
Copy link
Contributor

@saad-ali @msau42 Please set the milestone to 1.12.

@saad-ali
Copy link
Member

@saad-ali @msau42 Please set the milestone to 1.12.

Too late for 1.12. Past code freeze. Can consider for 1.13

@strowi strowi mentioned this pull request Sep 19, 2018
Closed
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit b875ad8 into kubernetes:master Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chakri-nelluri chakri-nelluri chakri-nelluri left review comments

@gnufied gnufied gnufied left review comments

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@gnufied gnufied

@chakri-nelluri chakri-nelluri

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable Flex Volume Drivers to support metrics
7 participants
@brahmaroutu @neolit123 @gnufied @chakri-nelluri @k8s-ci-robot @fejta-bot @saad-ali