Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated fluentd to 1.2.4 #67434

Merged
merged 1 commit into from
Aug 16, 2018
Merged

updated fluentd to 1.2.4 #67434

merged 1 commit into from
Aug 16, 2018

Conversation

monotek
Copy link
Member

@monotek monotek commented Aug 15, 2018 •
edited
Loading

What this PR does / why we need it:

  • updates fluentd in fluentd-elasticsearch to version 1.2.4
  • also updates activesupport, fluent-plugin-elasticsearch & oj gems

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

* updates fluentd in fluentd-elasticsearch to version 1.2.4
* also updates activesupport, fluent-plugin-elasticsearch & oj gems

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 15, 2018
@yue9944882
Copy link
Member

/cc dixudx

@monotek
Copy link
Member Author

monotek commented Aug 15, 2018

/assign @coffeepac

@neolit123
Copy link
Member

@monotek
please add a release note.
/ok-to-test

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 15, 2018
@monotek
Copy link
Member Author

monotek commented Aug 15, 2018

release notes added...

@coffeepac
Copy link
Contributor

/approve
/retest

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2018
@monotek monotek mentioned this pull request Aug 15, 2018
Closed
dixudx
dixudx approved these changes Aug 16, 2018
View reviewed changes
Copy link
Member

@dixudx dixudx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Please update cluster/addons/fluentd-elasticsearch/fluentd-es-ds.yaml accordingly to use latest v2.3.0 after this PR gets merged.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coffeepac, dixudx, monotek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 64445, 67459, 67434). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit dbe3b1a into kubernetes:master Aug 16, 2018
@monotek
Copy link
Member Author

monotek commented Aug 16, 2018

@coffeepac

Seems theres is still no automatic build of the image:

https://console.cloud.google.com/gcr/images/google-containers/GLOBAL/fluentd-elasticsearch?gcrImageListsize=50

Are these build jobs available in a repo, where i can contribute?
If so, where?

@coffeepac
Copy link
Contributor

nope. this is a google-internal image. Its on my list to make it not that. I'll file an issue against myself so I stop letting it fall off my list.

@aleks-mariusz
Copy link

any ideas when this will be generally available publicly to start using ?

@coffeepac
Copy link
Contributor

@aleks-mariusz I'm waiting for #67484 (comment) to get merged before I ask a googler to build. they can kick both jobs off at once. after that it will take ~24 hours.

Due to team geography (Ie: they're sleeping soon) I expect this will take ~36 hours

@aleks-mariusz
Copy link

cool, but i saw a typo in that issue (the first part of the commit has 6.3.2 but the second has 6.3.0).. made a mention of this on that issue as well.

@coffeepac
Copy link
Contributor

@aleks-mariusz available now, though its v2.3.1 . v2.3.0 wasn't built.

@neolit123
Copy link
Member

/sig instrumentation

@k8s-ci-robot k8s-ci-robot added the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Aug 24, 2018
@marpaia marpaia mentioned this pull request Dec 3, 2018
Merged
@monotek monotek mentioned this pull request Dec 5, 2018
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dixudx dixudx dixudx approved these changes

@coffeepac coffeepac Awaiting requested review from coffeepac

@piosz piosz Awaiting requested review from piosz

Assignees

@coffeepac coffeepac

@dixudx dixudx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@monotek @yue9944882 @neolit123 @coffeepac @k8s-ci-robot @k8s-github-robot @aleks-mariusz @dixudx