Stopy proxying etcd (localhost:4001) on https:/$MASTER_IP/etcd. #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue #603 is filed for flakiness of basic in e2e. |
|
LGTM but @brendanburns should verify. |
|
Does it notify Brendan if you mention @brendanburns or do you have to mention @brendandburns (note the extra d in the middle). That second username is the one that has been commenting on stuff, I think. |
|
He's got both :) |
|
yeah @brendanburns is my personal @brendandburns is my work. This is fine. I exposed it for ease of debugging mostly, fine to turn it off for security. --brendan |
brendandburns
added a commit
that referenced
this pull request
Jul 28, 2014
Stopy proxying etcd (localhost:4001) on https:/$MASTER_IP/etcd.
This was referenced Jul 13, 2015
Merged
Merged
Merged
vishh
pushed a commit
to vishh/kubernetes
that referenced
this pull request
Apr 6, 2016
The previous approach was brittle from within a container and was inconsistend. Fixes kubernetes#666
mqliang
pushed a commit
to mqliang/kubernetes
that referenced
this pull request
Dec 8, 2016
…aster (kubernetes#666) * Fixed kubernetes#665 : update checking if control machine is one of master * change default value of mapping_domain_to_ip to be true
mqliang
pushed a commit
to mqliang/kubernetes
that referenced
this pull request
Mar 3, 2017
…aster (kubernetes#666) * Fixed kubernetes#665 : update checking if control machine is one of master * change default value of mapping_domain_to_ip to be true
seans3
pushed a commit
to seans3/kubernetes
that referenced
this pull request
Apr 10, 2019
Propse KEP for Group Managed Service Accounts in Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small first step towards implementing the changes discussed in #443.
It removes the proxying of /etcd by the nginx proxy. This is necessary in order to cleanly remove Basic Auth from the system entirely, in order to replace it with token-based auth.
I ran e2e locally, and basic.sh failed while guestbook.sh passed.
The fact that the more complex test passed makes me think the failure was due to flakiness. So, I'm making the PR so travis can run e2e again.