Skip to content

Conversation

@MrHohn
Copy link
Member

@MrHohn MrHohn commented Mar 28, 2018

Cherry pick of #59019 on release-1.7.

#59019: Set --kubelet-preferred-address-types on apiserver by default

This is already cherrypicked into 1.9 and 1.8 and proved working. Cherrypicking it into 1.7 so that we can proceed with kubernetes/test-infra#7156 (enabling zonal DNS on GCP projects).

[GCE] Apiserver uses `InternalIP` as the most preferred kubelet address type by default.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 28, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 28, 2018
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 28, 2018
@k8s-ci-robot k8s-ci-robot requested review from bowei and vishh March 28, 2018 18:47
@MrHohn MrHohn changed the title Automated cherry pick of #59019: Set --kubelet-preferred-address-types on apiserver by Automated cherry pick of #59019 Mar 28, 2018
@MrHohn
Copy link
Member Author

MrHohn commented Mar 28, 2018

/assign @bowei @wojtek-t

@wojtek-t
Copy link
Member

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2018
@wojtek-t wojtek-t added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 29, 2018
@wojtek-t wojtek-t added this to the v1.7 milestone Mar 29, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit e8846c1 into kubernetes:release-1.7 Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants