Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes 'Zone is empty' errors in PD upgrade tests; skips pd tests with inline volume in multizone clusters #61303

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Fixes 'Zone is empty' errors in PD upgrade tests; skips pd tests with inline volume in multizone clusters #61303

merged 1 commit into from
Mar 23, 2018
+38 −0

Conversation

verult
Copy link
Contributor

@verult verult commented Mar 16, 2018

What this PR does / why we need it: This is the same as #61243, except it includes the GetClusterZone() method not implemented in 1.9 yet.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #61242

Special notes for your reviewer: This needs to be cherry-picked to 1.8 and 1.7 as well

/assign @saad-ali
/cc @wojtek-t
/sig storage
/sig gcp

Release note:

Fixes storage e2e test failures in GKE regional clusters.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Mar 16, 2018
@k8s-ci-robot k8s-ci-robot added sig/gcp size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 16, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 16, 2018
@wojtek-t
Copy link
Member

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: verult, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2018
@wojtek-t wojtek-t added this to the v1.9 milestone Mar 19, 2018
@wojtek-t
Copy link
Member

@jpbetz

@saad-ali
Copy link
Member

/status approved-for-milestone

@saad-ali
Copy link
Member

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 19, 2018
@saad-ali
Copy link
Member

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Mar 19, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@jpbetz @saad-ali @verult @wojtek-t

Pull Request Labels
  • sig/gcp sig/storage: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@verult
Copy link
Contributor Author

verult commented Mar 22, 2018

gentle ping @jpbetz

@jpbetz jpbetz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 22, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit ee10d80 into kubernetes:release-1.9 Mar 23, 2018
This was referenced Mar 23, 2018
Merged
Merged
@verult verult deleted the pd-multizone-fix-1.9 branch March 24, 2018 01:36
k8s-github-robot pushed a commit that referenced this pull request Mar 27, 2018
Merge pull request #61605 from verult/automated-cherry-pick-of-#61303…
c3980a0 
…-upstream-release-1.7

Automatic merge from submit-queue.

Automated cherry pick of #61303: Fixes 'Zone is empty' errors in PD upgrade tests; skips pd

Cherry pick of #61303 on release-1.7.

#61303: Fixes 'Zone is empty' errors in PD upgrade tests; skips pd
k8s-github-robot pushed a commit that referenced this pull request Mar 27, 2018
Merge pull request #61606 from verult/automated-cherry-pick-of-#61303…
e246c88 
…-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #61303: Fixes 'Zone is empty' errors in PD upgrade tests; skips pd

Cherry pick of #61303 on release-1.8.

#61303: Fixes 'Zone is empty' errors in PD upgrade tests; skips pd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@jpbetz jpbetz

@saad-ali saad-ali

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
6 participants
@verult @wojtek-t @k8s-ci-robot @saad-ali @k8s-github-robot @jpbetz