Skip to content

Automated cherry pick of #59019 #59145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2018
Merged

Automated cherry pick of #59019 #59145

merged 1 commit into from
Feb 1, 2018

Conversation

MrHohn
Copy link
Member

@MrHohn MrHohn commented Jan 31, 2018 •
edited
Loading

Cherry pick of #59019 on release-1.8.

#59019: Set --kubelet-preferred-address-types on apiserver by default

[GCE] Apiserver uses `InternalIP` as the most preferred kubelet address type by default.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 31, 2018
@k8s-ci-robot k8s-ci-robot requested review from bowei and gmarek January 31, 2018 19:18
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 31, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 31, 2018
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 31, 2018
@MrHohn
Copy link
Member Author

MrHohn commented Jan 31, 2018

/assign @bowei @cjcullen

@bowei
Copy link
Member

bowei commented Jan 31, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, MrHohn

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2018
@BenTheElder
Copy link
Member

/retest

@MrHohn
Copy link
Member Author

MrHohn commented Feb 1, 2018

/assign @jpbetz

@wojtek-t wojtek-t added this to the v1.8 milestone Feb 1, 2018
@wojtek-t
Copy link
Member

wojtek-t commented Feb 1, 2018

@jpbetz - friendly ping for cherrypick approval

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Labels Incomplete

@MrHohn @bowei @cjcullen @jpbetz

Action required: This pull request requires label changes. If the required changes are not made within 2 days, the pull request will be moved out of the v1.8 milestone.

kind: Must specify exactly one of kind/bug, kind/cleanup or kind/feature.
priority: Must specify exactly one of priority/critical-urgent, priority/important-longterm or priority/important-soon.
sig owner: Must specify at least one label prefixed with sig/.

Help

@jpbetz jpbetz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Feb 1, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@MrHohn
Copy link
Member Author

MrHohn commented Feb 1, 2018

/retest

1 similar comment
@MrHohn
Copy link
Member Author

MrHohn commented Feb 1, 2018

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit f745eed into kubernetes:release-1.8 Feb 1, 2018
@k8s-ci-robot
Copy link
Contributor

@MrHohn: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gke 7015a5e link /test pull-kubernetes-e2e-gke

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@gmarek gmarek Awaiting requested review from gmarek

Assignees

@jpbetz jpbetz

@bowei bowei

@cjcullen cjcullen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. milestone/incomplete-labels release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
8 participants
@MrHohn @bowei @k8s-ci-robot @BenTheElder @wojtek-t @k8s-github-robot @jpbetz @cjcullen