Promote v1alpha1 meta to v1beta1 #59059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/XL
k8s-ci-robot
requested review from
caesarxuchao,
deads2k,
enj,
gmarek,
jsafrane,
jszczepkowski,
juanvallejo,
kow3ns,
lavalamp,
liggitt,
mengqiy,
nikhita,
resouer,
sttts and
thockin
k8s-ci-robot
added
the
sig/api-machinery
Contributor
Author
|
I expect any bugs / gaps to be identified by #55637 and subsequent changes. |
smarterclayton
force-pushed
the
move_partial_object
branch
from
3e2f709 to
c067469
Compare
k8s-ci-robot
added
release-note
smarterclayton
force-pushed
the
move_partial_object
branch
from
c067469 to
b524f09
Compare
Contributor
|
Looks like a straight sed. You don't want to keep the alpha level too for an easier transition for clients? |
Contributor
Author
|
Figure that we're going to kill it anyway this release, so it was easier to
completely move.
…On Tue, Jan 30, 2018 at 2:25 PM, David Eads ***@***.***> wrote:
Looks like a straight sed. You don't want to keep the alpha level too for
an easier transition for clients?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#59059 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p6fmfcQAMn1Tp7ouUJSTV8aAt_ZRks5tP2zDgaJpZM4RyzdA>
.
|
smarterclayton
force-pushed
the
move_partial_object
branch
2 times, most recently
from
0b04646 to
e45779f
Compare
Contributor
|
sgtm |
Contributor
Author
|
/retest |
smarterclayton
force-pushed
the
move_partial_object
branch
from
e45779f to
4f43bdd
Compare
No code changes, just renames
smarterclayton
force-pushed
the
move_partial_object
branch
from
4f43bdd to
d07a608
Compare
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, smarterclayton The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/retest Review the full test history for this PR. Silence the bot with an |
|
Automatic merge from submit-queue (batch tested with PRs 59158, 38320, 59059, 55516, 59357). If you want to cherry-pick this change to another branch, please follow the instructions here. |
6 tasks
k8s-github-robot
pushed a commit
that referenced
this pull request
Feb 23, 2018
…-response-proto-v2 Automatic merge from submit-queue (batch tested with PRs 55637, 57461, 60268, 60290, 60210). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update get.go to use server-side printing Addresses part of #58536 Adds support for server-side changes implemented in #40848 and updated in #59059 @deads2k per our discussion, opening this as a separate PR. This wires through a per-request use of `as=Table;...` header parameters using the resource builder from the `kube get` command. #### Items to consider going forward: - [ ] Figure out how to handle sorting when dealing with multiple Table objects from the server - [ ] Figure out sorting when dealing with a mixed response from the server consisting of Tables and normal resources (`--sort-by` is handled in this PR by falling back to old behavior) - [ ] Filtering: How should we filter Table objects? Separate filter for rows? Filter on jsonpath? We have access to partial object metadata for each table row - not enough to know how to filter pods, for example but we could request that the original object be included along with each Table.Row by adding an `includeObject` param in the client request. #### Resources that do not yet support Table output - [ ] Namespaces - [ ] Services - [ ] Service catalog resources: https://github.com/kubernetes-incubator/service-catalog/blob/master/pkg/apis/servicecatalog/v1beta1/types.go **Release note**: ```release-note NONE ```
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No code changes, just renames. We can discuss if there are any field / naming changes here or in a follow-up
Parent #58536
Fixes #53224
Prereq to #55637
@kubernetes/sig-api-machinery-pr-reviews @deads2k