bugfix(mount): lstat with abs path of parent instead of '/..' #58433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
yue9944882
commented
Jan 18, 2018
pkg/util/mount/mount_linux.go
Outdated
| @@ -265,7 +265,7 @@ func (mounter *Mounter) IsLikelyNotMountPoint(file string) (bool, error) { | |||
| if err != nil { | |||
| return true, err | |||
| } | |||
| rootStat, err := os.Lstat(file + "/..") | |||
| rootStat, err := os.Lstat(filepath.Dir(strings.TrimSuffix("/"))) | |||
There was a problem hiding this comment.
I'm not sure whether trying to remove tailing slash here is necessary
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
yue9944882
force-pushed
the
bugfix/lstat-parent-with-abs-path
branch
from
d7e0377
to
c398269
Compare
|
/kind bug |
k8s-ci-robot
added
the
sig/node
|
/sig storage |
k8s-ci-robot
added
the
sig/storage
|
/assign |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/test pull-kubernetes-e2e-kubeadm-gce-canary |
|
@yue9944882: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, msau42, yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these OWNERS Files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 59103, 58433). If you want to cherry-pick this change to another branch, please follow the instructions here. |
4 tasks
This was referenced Mar 14, 2018
4 tasks
k8s-github-robot
pushed a commit
that referenced
this pull request
Mar 15, 2018
…33-upstream-release-1.8 Automatic merge from submit-queue. Automated cherry pick of #58433: bugfix(mount): lstat with abs path of parent instead of '/..' Cherry pick of #58433 on release-1.8. #58433: bugfix(mount): lstat with abs path of parent instead of '/..' ```release-note Fix a regression that prevented cleanup of a `subPath` volume mount ```
k8s-github-robot
pushed a commit
that referenced
this pull request
Mar 15, 2018
…33-upstream-release-1.9 Automatic merge from submit-queue. Automated cherry pick of #58433: bugfix(mount): lstat with abs path of parent instead of '/..' Cherry pick of #58433 on release-1.9. #58433: bugfix(mount): lstat with abs path of parent instead of '/..' Fixes: #61178 ```release-note Fix a regression that prevented cleanup of a `subPath` volume mount ```
k8s-github-robot
pushed a commit
that referenced
this pull request
Mar 15, 2018
…33-upstream-release-1.7 Automatic merge from submit-queue. Automated cherry pick of #58433: bugfix(mount): lstat with abs path of parent instead of '/..' Cherry pick of #58433 on release-1.7. #58433: bugfix(mount): lstat with abs path of parent instead of '/..' ```release-note Fix a regression that prevented cleanup of a `subPath` volume mount ```
k8s-github-robot
pushed a commit
that referenced
this pull request
Apr 13, 2018
Automatic merge from submit-queue (batch tested with PRs 61608, 62304). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove isNotDir error check **What this PR does / why we need it**: This check was supposed to handle the "subpath file" scenario, but: 1. It's wrong (should have been !) 2. It's not needed anymore. `IsLikelyNotMountPoint` was fixed to handle file mounts via #58433 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
wgliang
pushed a commit
to wgliang/utils
that referenced
this pull request
Jun 11, 2018
Automatic merge from submit-queue (batch tested with PRs 61608, 62304). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove isNotDir error check **What this PR does / why we need it**: This check was supposed to handle the "subpath file" scenario, but: 1. It's wrong (should have been !) 2. It's not needed anymore. `IsLikelyNotMountPoint` was fixed to handle file mounts via kubernetes/kubernetes#58433 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If a nfs volume with improper permission is mounted on a Pod, operation of deleting this Pod will fail and the pod itself will be stuck at a 'TERMINATING' status. Kubelet cannot reconcile it correctly.
This is because kubelet will try to find the mount-point with '..' file which needs
xpermission of dir. When it's forbidden, the nfs volume will never umount without a correct mount-point finded.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #57095
Special notes for your reviewer:
Release note: