Skip to content

Add code-of-conduct.md to staging repos #57473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-github-robot merged 1 commit into from
Dec 23, 2017
Merged

Add code-of-conduct.md to staging repos #57473

k8s-github-robot merged 1 commit into from
Dec 23, 2017
+30 −0

Conversation

@spiffxp
Copy link
Contributor

@spiffxp spiffxp commented Dec 20, 2017

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 20, 2017

@spiffxp: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

Details

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added retest-not-required-docs-only do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 20, 2017
@sttts
Copy link
Contributor

sttts commented Dec 20, 2017 •
edited
Loading

/hold
/lgtm
/approve no-issue

Hold until kubernetes/metrics#14 is merged.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 20, 2017
@sttts sttts mentioned this pull request Dec 20, 2017
Merged
@sttts
Copy link
Contributor

sttts commented Dec 20, 2017

@liggitt @deads2k @DirectXMan12 for approval

@sttts
Copy link
Contributor

sttts commented Dec 20, 2017

/retest

@spiffxp
Copy link
Contributor Author

spiffxp commented Dec 20, 2017

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 20, 2017
@spiffxp spiffxp mentioned this pull request Dec 22, 2017
Closed
@sttts
Copy link
Contributor

sttts commented Dec 22, 2017

/unhold
/approve no-issue

@sttts sttts assigned thockin and unassigned gmarek Dec 22, 2017
@sttts sttts removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 22, 2017
@sttts
Copy link
Contributor

sttts commented Dec 22, 2017

@thockin for approval.

@thockin
Copy link
Member

thockin commented Dec 23, 2017

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 23, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp, sttts, thockin

Associated issue: #1527

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2017
@k8s-github-robot
Copy link

k8s-github-robot commented Dec 23, 2017

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 8a4a39d into kubernetes:master Dec 23, 2017
@spiffxp spiffxp deleted the add-code-of-conduct-to-staging-repos branch December 27, 2017 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sttts sttts

@thockin thockin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@spiffxp @k8s-ci-robot @sttts @thockin @k8s-github-robot @gmarek