Skip to content

Update code-of-conduct.md #57469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-github-robot merged 1 commit into from
Dec 20, 2017
Merged

Update code-of-conduct.md #57469

k8s-github-robot merged 1 commit into from
Dec 20, 2017
+2 −4

Conversation

@spiffxp
Copy link
Contributor

@spiffxp spiffxp commented Dec 20, 2017

Refer to kubernetes/community as authoritative source for code of conduct

ref: kubernetes/community#1527

@spiffxp
Update code-of-conduct.md
5fe3d9d 
Refer to kubernetes/community as authoritative source for code of conduct
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 20, 2017

@spiffxp: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

Details

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. retest-not-required-docs-only cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 20, 2017
@jbeda
Copy link
Contributor

jbeda commented Dec 20, 2017

/release-note-none
/approve no-issue

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 20, 2017
cblecker
cblecker approved these changes Dec 20, 2017
View reviewed changes
Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 20, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, jbeda, spiffxp

Associated issue: #1527

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@spiffxp
Copy link
Contributor Author

spiffxp commented Dec 20, 2017

/retest

@k8s-github-robot
Copy link

k8s-github-robot commented Dec 20, 2017

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 49e3446 into kubernetes:master Dec 20, 2017
@spiffxp spiffxp deleted the update-code-of-conduct branch January 4, 2018 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cblecker cblecker cblecker approved these changes

Assignees

@jbeda jbeda

@cblecker cblecker

@dchen1107 dchen1107

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@spiffxp @k8s-ci-robot @jbeda @k8s-github-robot @cblecker @dchen1107