Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check both name and ports for azure health probes #56918

Merged
merged 1 commit into from
Dec 12, 2017
Merged

Check both name and ports for azure health probes #56918

merged 1 commit into from
Dec 12, 2017

Conversation

feiskyer
Copy link
Member

@feiskyer feiskyer commented Dec 7, 2017

What this PR does / why we need it:

Check both name and ports for azure health probes, so that probe ports could follow nodePorts changes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #56898

Special notes for your reviewer:

Should be cherry-picked in 1.7, 1.8, 1.9.

Release note:

BUG FIX: Check both name and ports for azure health probes

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 7, 2017
@feiskyer
Copy link
Member Author

feiskyer commented Dec 7, 2017

/sig azure

@feiskyer
Copy link
Member Author

feiskyer commented Dec 7, 2017

/area cloudprovider

@feiskyer feiskyer added this to the v1.9 milestone Dec 7, 2017
@feiskyer feiskyer added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed milestone/incomplete-labels labels Dec 7, 2017
@andyzhangx
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2017
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2017
@feiskyer
Copy link
Member Author

feiskyer commented Dec 7, 2017

/assign @brendandburns

@andyzhangx
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2017
@feiskyer
Copy link
Member Author

feiskyer commented Dec 7, 2017

/retest

@feiskyer feiskyer mentioned this pull request Dec 7, 2017
Closed
@dixudx
Copy link
Member

dixudx commented Dec 7, 2017

@feiskyer could you squash the commits? No need to have multiple commits for a single checking.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2017
@feiskyer
Copy link
Member Author

feiskyer commented Dec 7, 2017

@dixudx Thanks for reviewing. Squashed commits. PTAL.

@dixudx
Copy link
Member

dixudx commented Dec 7, 2017

/lgtm

@jberkus jberkus mentioned this pull request Dec 10, 2017
Closed
@feiskyer
Copy link
Member Author

@brendandburns Could you also help to approve milestone?

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@colemickens
Copy link
Contributor

colemickens commented Dec 11, 2017 •
edited
Loading

I don't think this PR does anything in reality. The probe name already encodes the Port... so this check doesn't add anything.

See the way the load balancer probe names are determined:

kubernetes/pkg/cloudprovider/providers/azure/azure_util.go

Line 335 in 630dbed

func getLoadBalancerRuleName(service *v1.Service, port v1.ServicePort, subnetName *string) string {
(the lbRuleName is used as the expected Probe name as well, etc)

(Can you revert the impl and run the tests again and verify they fail? I think they're going to pass.)

@colemickens
Copy link
Contributor

Also, your text in your PR mentions "nodePorts" but I don't see you checking that field.

@colemickens
Copy link
Contributor

colemickens commented Dec 11, 2017 •
edited
Loading

/lgtm cancel

Canceled because the tests pass without the implementation changes.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2017
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Current

@andyzhangx @brendandburns @colemickens @dixudx @feiskyer @rootfs

Note: This pull request is marked as priority/critical-urgent, and must be updated every 1 day during code freeze.

Example update:

ACK.  In progress
ETA: DD/MM/YYYY
Risks: Complicated fix required
Pull Request Labels
  • sig/azure: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@colemickens
Copy link
Contributor

colemickens commented Dec 12, 2017 •
edited
Loading

Last comment, I'm not even sure it's worth checking the NodePort. The NodePort is assigned as Service creation time, as is the Service GUID. The service guid is also encoded in the probe name. I can't think of any time that a NodePort is updated for an existing Service.

I forget the NodePort is user edittable.

@enisoc
Copy link
Member

enisoc commented Dec 12, 2017

I'm removing the milestone because it appears this isn't ready yet and the issue has existed since before 1.9, so I don't think it should block 1.9.0. Please let me know if you disagree.

@enisoc enisoc removed this from the v1.9 milestone Dec 12, 2017
@feiskyer
Copy link
Member Author

feiskyer commented Dec 12, 2017 •
edited
Loading

@colemickens probe.Port is actually nodePort and it could be changed by user.

@enisoc This is a fix for #56898, and the PR itself has already ready. It should also be cherry-picked to old releases. Please help to add the milestone back.

@feiskyer
Copy link
Member Author

I forget the NodePort is user edittable.

@colemickens add the magical lgtm lable back?

@colemickens
Copy link
Contributor

colemickens commented Dec 12, 2017 •
edited
Loading

Spoke with @feiskyer. I read this wrong, probe.Port is different than the servicePort.Port.
/lgtm
/status approved-for-milestone

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. status/approved-for-milestone labels Dec 12, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, brendandburns, colemickens, dixudx, feiskyer

Associated issue: #56898

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@feiskyer feiskyer added this to the v1.9 milestone Dec 12, 2017
@feiskyer
Copy link
Member Author

@colemickens thanks. I also added the milestone back.

@enisoc @colemickens thanks for reviewing this.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 56599, 56824, 56918, 56967, 56959). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit b4356de into kubernetes:master Dec 12, 2017
@feiskyer feiskyer deleted the azure-probe branch December 12, 2017 04:57
This was referenced Dec 12, 2017
Merged
Merged
k8s-github-robot pushed a commit that referenced this pull request Dec 13, 2017
Merge pull request #57078 from feiskyer/automated-cherry-pick-of-#569…
dce4b4c 
…18-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #56918

Cherry pick of #56918 on release-1.8.

#56918: Check both name and ports for azure health probes
k8s-github-robot pushed a commit that referenced this pull request Dec 15, 2017
Merge pull request #57077 from feiskyer/automated-cherry-pick-of-#569…
8639776 
…18-upstream-release-1.7

Automatic merge from submit-queue.

Automated cherry pick of #56918

Cherry pick of #56918 on release-1.7.

#56918: Check both name and ports for azure health probes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@colemickens colemickens

@andyzhangx andyzhangx

@dixudx dixudx

@brendandburns brendandburns

@rootfs rootfs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

Azure Load Balancer Health Probe not configured correctly