Use struct key for TLS cache #56811
Merged
Use struct key for TLS cache #56811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
liggitt
commented
Dec 4, 2017
•
liggitt
commented
k8s-ci-robot
added
do-not-merge/release-note-label-needed
lavalamp
reviewed
Dec 4, 2017
| func (t tlsCacheKey) String() string { | ||
| keyText := "<none>" | ||
| if len(keyData) > 0 { | ||
| keyText = "<redacted>" |
There was a problem hiding this comment.
I was thinking of hashing it at construction time, but this is at least better than what was there.
k8s-ci-robot
added
release-note-none
liggitt
added
kind/cleanup
|
/approve no-issue |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, liggitt Associated issue requirement bypassed by: liggitt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all Tests are more than 96 hours old. Re-running tests. |
|
Automatic merge from submit-queue (batch tested with PRs 56108, 56811, 57335, 57331, 54530). If you want to cherry-pick this change to another branch, please follow the instructions here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.