Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump addon manager version used to 6.5 #55782

Merged
merged 1 commit into from
Nov 16, 2017

Conversation

x13n
Copy link
Member

@x13n x13n commented Nov 15, 2017

What this PR does / why we need it:
Bump addon manager version to use #55466. This adds leader election-like mechanism to addon manager.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Special notes for your reviewer:
Release note copied from #55466. This is intended to be cherrypicked into 1.7 and 1.8 branches.

Release note:

Addon manager supports HA masters.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 15, 2017
@@ -13,7 +13,7 @@ spec:
- name: kube-addon-manager
# When updating version also bump it in:
# - test/kubemark/resources/manifests/kube-addon-manager.yaml
image: gcr.io/google-containers/kube-addon-manager:v6.4-beta.2
image: gcr.io/danielmk-gke-dev/kube-addon-manager:v6.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to use private registries. This should come from google-containers.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - leftover from testing. Changed to google-containers now. Thanks for catching this!

@wojtek-t
Copy link
Member

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wojtek-t, x13n

Associated issue: 55466

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit ee2cf0b into kubernetes:master Nov 16, 2017
@x13n x13n deleted the addon-manager branch November 16, 2017 09:15
k8s-github-robot pushed a commit that referenced this pull request Nov 16, 2017
…pstream-release-1.7

Automatic merge from submit-queue.

Automated cherry pick of #55782

Cherry pick of #55782 on release-1.7.

#55782: Bump addon manager version used to 6.5
k8s-github-robot pushed a commit that referenced this pull request Nov 16, 2017
…pstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #55782

Cherry pick of #55782 on release-1.8.

#55782: Bump addon manager version used to 6.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants