Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly set route_localnet on nodes & masters. #55004

Merged
merged 1 commit into from
Nov 2, 2017
Merged

Explicitly set route_localnet on nodes & masters. #55004

merged 1 commit into from
Nov 2, 2017

Conversation

ikehz
Copy link
Contributor

@ikehz ikehz commented Nov 2, 2017 •
edited by wojtek-t
Loading

Allow for loopback addresses to be used for routing, specifically to
enable metadata proxy on master nodes.

What this PR does / why we need it: Enables metadata proxy (#8867) to work on the master. This is already being done on the nodes by kube-proxy, but this makes it explicit, and sets it on the master where kube-proxy doesn't run. Thanks to @dnardo for figuring this out!

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): fixes #54736
Fixes #

Special notes for your reviewer:

Release note:

Set route_localnet on nodes & masters in GCE

Explicitly set route_localnet on nodes & masters.
a051a54 
Allow for loopback addresses to be used for routing, specifically to
enable metadata proxy on master nodes.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 2, 2017
@ikehz
Copy link
Contributor Author

ikehz commented Nov 2, 2017

/assign @dnardo @mikedanese
/unassign @vishh @jszczepkowski

@k8s-ci-robot k8s-ci-robot assigned dnardo and mikedanese and unassigned vishh and jszczepkowski Nov 2, 2017
@dnardo
Copy link
Contributor

dnardo commented Nov 2, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2017
@mikedanese
Copy link
Member

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dnardo, ihmccreery, mikedanese

Associated issue: 8867

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2017
@MrHohn MrHohn mentioned this pull request Nov 2, 2017
Merged
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 55004, 54957). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 6232f36 into kubernetes:master Nov 2, 2017
@MrHohn MrHohn mentioned this pull request Nov 2, 2017
Closed
@ikehz
Copy link
Contributor Author

ikehz commented Nov 8, 2017

@cjcullen Can you please propose that this gets cherry picked into 1.8 and 1.7? I don't have permissions to do so. :(

https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md#propose-a-cherry-pick

@cjcullen cjcullen added this to the v1.7 milestone Nov 10, 2017
This was referenced Nov 10, 2017
Merged
Merged
k8s-github-robot pushed a commit that referenced this pull request Nov 15, 2017
Merge pull request #55498 from ihmccreery/automated-cherry-pick-of-#5…
a6a31a0 
…5004-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #55004

Cherry pick of #55004 on release-1.8.

#55004: Explicitly set route_localnet on nodes & masters.
@wojtek-t
Copy link
Member

@ihmccreery @cjcullen - I'm fine with cherrypicking this, but please add a user-friendly release note describing what this is fixing to this PR.

@php-coder php-coder mentioned this pull request Dec 1, 2017
Merged
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 3, 2018
k8s-github-robot pushed a commit that referenced this pull request Jan 4, 2018
Merge pull request #55497 from ihmccreery/automated-cherry-pick-of-#5…
88ef684 
…5004-upstream-release-1.7

Automatic merge from submit-queue.

Automated cherry pick of #55004

Cherry pick of #55004 on release-1.7.

#55004: Explicitly set route_localnet on nodes & masters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mikedanese mikedanese

@dnardo dnardo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

Fluentd pod failed to become ready on master
9 participants
@ikehz @dnardo @mikedanese @k8s-github-robot @wojtek-t @vishh @cjcullen @jszczepkowski @k8s-ci-robot