Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move fluentd-gcp out of host network #54395

Merged
merged 1 commit into from
Oct 27, 2017
Merged

Move fluentd-gcp out of host network #54395

merged 1 commit into from
Oct 27, 2017

Conversation

crassirostris
Copy link

Since metadata proxy doesn't filter service account after all, make fluentd-gcp addon run in its own network

This will mitigate the problem with port collision

[fluentd-gcp addon] Fluentd now runs in its own network, not in the host one.

@crassirostris crassirostris added area/logging kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Oct 23, 2017
@crassirostris crassirostris added this to the v1.9 milestone Oct 23, 2017
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 23, 2017
@crassirostris
Copy link
Author

/approve no-issue

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2017
@loburm
Copy link
Contributor

loburm commented Oct 27, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crassirostris, loburm

Associated issue requirement bypassed by: crassirostris

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 50776, 54395). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit fc8bfe2 into kubernetes:master Oct 27, 2017
This was referenced Oct 27, 2017
Merged
Merged
k8s-github-robot pushed a commit that referenced this pull request Oct 27, 2017
Merge pull request #54695 from crassirostris/automated-cherry-pick-of…
2cfd7db 
…-#54395-upstream-release-1.7

Automatic merge from submit-queue.

Automated cherry pick of #54395

Cherry pick of #54395 on release-1.7.

#54395: Move fluentd-gcp out of host network

```release-note
[fluentd-gcp addon] Fluentd now runs in its own network, not in the host one.
```
k8s-github-robot pushed a commit that referenced this pull request Oct 27, 2017
Merge pull request #54694 from crassirostris/automated-cherry-pick-of…
256750e 
…-#54395-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #54395

Cherry pick of #54395 on release-1.8.

#54395: Move fluentd-gcp out of host network

```release-note
[fluentd-gcp addon] Fluentd now runs in its own network, not in the host one.
```
@MrHohn MrHohn mentioned this pull request Oct 28, 2017
Closed
@roberthbailey roberthbailey mentioned this pull request Aug 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@loburm loburm

@fgrzadkowski fgrzadkowski

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/logging cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
5 participants
@crassirostris @loburm @k8s-github-robot @fgrzadkowski @k8s-ci-robot