Skip to content

bump debian-hyperkube-base to 0.5 since CNI gets bumped #54272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-github-robot merged 1 commit into from
Oct 22, 2017
Merged

bump debian-hyperkube-base to 0.5 since CNI gets bumped #54272

k8s-github-robot merged 1 commit into from
Oct 22, 2017
+4 −4

Conversation

@dixudx
Copy link
Member

@dixudx dixudx commented Oct 20, 2017

What this PR does / why we need it:
xref discussion in #51250

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:
/assign @ixdy @luxas

Release note:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 20, 2017
@dixudx
Copy link
Member Author

dixudx commented Oct 20, 2017

@ixdy @luxas Please help label milestone v1.9.

@dixudx
Copy link
Member Author

dixudx commented Oct 20, 2017

/retest

luxas
luxas approved these changes Oct 20, 2017
View reviewed changes
Copy link
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

if it's ok for @ixdy

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2017
@luxas
Copy link
Member

luxas commented Oct 20, 2017

/retest

@dixudx
Copy link
Member Author

dixudx commented Oct 20, 2017

ping @mikedanese Needs your approval. Thanks

@dims
Copy link
Member

dims commented Oct 20, 2017

/assign @jbeda

@ixdy
Copy link
Contributor

ixdy commented Oct 20, 2017

/lgtm cancel

needs update to build/root/WORKSPACE too; standby for sha

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2017
@ixdy
Copy link
Contributor

ixdy commented Oct 20, 2017

gcr.io/google-containers/debian-hyperkube-base-amd64:0.5 has digest sha256:d216b425004fcb6d8047f74e81b30e7ead55f73e73511ca53a329c358786b6c9.

@ixdy ixdy mentioned this pull request Oct 20, 2017
Merged
@dixudx dixudx force-pushed the bump_debian-hyperkube-base_due_CNI branch from aaf06b5 to 7ec31b6 Compare October 21, 2017 03:47
@dixudx
Copy link
Member Author

dixudx commented Oct 21, 2017

@ixdy Thanks. Already bumped the new sha. PTAL. Thanks.

@dixudx
Copy link
Member Author

dixudx commented Oct 21, 2017

/retest

@ixdy
Copy link
Contributor

ixdy commented Oct 21, 2017 •
edited
Loading

/lgtm

thanks! just need to find an approver for cluster/images/hyperkube now.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2017
@dixudx
Copy link
Member Author

dixudx commented Oct 21, 2017

ping @eparis @roberthbailey Needs your approval. Thanks.

@roberthbailey
Copy link
Contributor

roberthbailey commented Oct 22, 2017

/approve

@k8s-github-robot
Copy link

k8s-github-robot commented Oct 22, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dixudx, ixdy, luxas, roberthbailey

Associated issue: 51250

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2017
@k8s-github-robot
Copy link

k8s-github-robot commented Oct 22, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

k8s-github-robot commented Oct 22, 2017

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 6f06408 into kubernetes:master Oct 22, 2017
@dixudx dixudx deleted the bump_debian-hyperkube-base_due_CNI branch October 23, 2017 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@luxas luxas luxas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jbeda jbeda

@luxas luxas

@ixdy ixdy

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@dixudx @luxas @dims @ixdy @roberthbailey @k8s-github-robot @jbeda @k8s-ci-robot