Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix retry logic in service controller #54184

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Fix retry logic in service controller #54184

merged 1 commit into from
Oct 24, 2017

Conversation

MrHohn
Copy link
Member

@MrHohn MrHohn commented Oct 19, 2017 •
edited
Loading

What this PR does / why we need it: Make service controller don't retry on doNotRetry service update failure.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #54183

Special notes for your reviewer:
/assign @nicksardo @bowei

Release note:

Fix for service controller so that it won't retry on doNotRetry service update failure.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 19, 2017
@nicksardo
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2017
@MrHohn
Copy link
Member Author

MrHohn commented Oct 19, 2017

/retest

@MrHohn
Copy link
Member Author

MrHohn commented Oct 19, 2017

/assign @mikedanese
for approval.

@bowei
Copy link
Member

bowei commented Oct 23, 2017

/approve

1 similar comment
@MrHohn
Copy link
Member Author

MrHohn commented Oct 24, 2017

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, MrHohn, nicksardo

Associated issue: 54183

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 54107, 54184, 54377, 54094, 54111). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 4ca155c into kubernetes:master Oct 24, 2017
This was referenced Oct 24, 2017
Merged
Merged
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 25, 2017
@MrHohn
Copy link
Member Author

MrHohn commented Oct 25, 2017

/release-note

@k8s-ci-robot
Copy link
Contributor

@MrHohn: the /release-note and /release-note-action-required commands have been deprecated.
Please edit the release-note block in the PR body text to include the release note. If the release note requires additional action include the string action required in the release note. For example:

```release-note
Some release note with action required.
```

In response to this:

/release-note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-github-robot pushed a commit that referenced this pull request Oct 26, 2017
Merge pull request #54520 from MrHohn/automated-cherry-pick-of-#54184…
fcd8b7c 
…-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #54184

Cherry pick of #54184 on release-1.8.

#54184: Fix retry logic in service controller
k8s-github-robot pushed a commit that referenced this pull request Oct 30, 2017
Merge pull request #54521 from MrHohn/automated-cherry-pick-of-#54184…
4d27fe5 
…-upstream-release-1.7

Automatic merge from submit-queue.

Automated cherry pick of #54184

Cherry pick of #54184 on release-1.7.

#54184: Fix retry logic in service controller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nicksardo nicksardo

@bowei bowei

@mikedanese mikedanese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Service controller retries on doNotRetry service update failure
6 participants
@MrHohn @nicksardo @bowei @k8s-github-robot @k8s-ci-robot @mikedanese