Skip to content

Ensure network policy conversion round trips nil from fields #54106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-github-robot merged 1 commit into from
Oct 25, 2017
Merged

Ensure network policy conversion round trips nil from fields #54106

k8s-github-robot merged 1 commit into from
Oct 25, 2017

Conversation

@liggitt
Copy link
Member

@liggitt liggitt commented Oct 17, 2017 •
edited
Loading

Fixes #53906 (inability to apply network policies against v1 in 1.7)

  • Changes non-mutation check to API equality (which treats nil and [] slices identically)
  • Fixed bug in manual conversion that took an input of nil and produced an output of []
Restores the ability to apply network policy objects against the networking.k8s.io/v1 API

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 17, 2017

@liggitt: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

Details

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 17, 2017
@liggitt liggitt force-pushed the networkpolicy-apply branch from 5e07827 to 04be59c Compare October 18, 2017 00:02
@liggitt liggitt added this to the v1.7 milestone Oct 18, 2017
@liggitt
Copy link
Member Author

liggitt commented Oct 18, 2017

cc @kubernetes/sig-network-api-reviews @kubernetes/sig-network-pr-reviews

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 18, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Oct 18, 2017
@liggitt liggitt assigned dixudx and wojtek-t and unassigned lavalamp and cmluciano Oct 18, 2017
@cmluciano
Copy link

cmluciano commented Oct 18, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2017
@k8s-github-robot
Copy link

k8s-github-robot commented Oct 18, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cmluciano, liggitt

Associated issue: 53906

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@liggitt
Copy link
Member Author

liggitt commented Oct 24, 2017

ping @wojtek-t for cherrypick approval

@wojtek-t
Copy link
Member

wojtek-t commented Oct 25, 2017

@liggitt - sorry for the delay. I don't know why, but I though it's a PR to the master branch and waited for it to be merged before cherrypicking to 1.7. Apparently it's not the case.

Yes - the cherrypick is reasonable. Approved.

@wojtek-t wojtek-t added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed cherrypick-candidate labels Oct 25, 2017
@wojtek-t wojtek-t removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 25, 2017
@k8s-github-robot
Copy link

k8s-github-robot commented Oct 25, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

k8s-github-robot commented Oct 25, 2017

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 1531194 into kubernetes:release-1.7 Oct 25, 2017
@liggitt liggitt deleted the networkpolicy-apply branch April 22, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cmluciano cmluciano

@dixudx dixudx

@wojtek-t wojtek-t

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.7

Development

Successfully merging this pull request may close these issues.

7 participants

@liggitt @k8s-ci-robot @cmluciano @k8s-github-robot @wojtek-t @lavalamp @dixudx