Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update busybox image link to gcr.io for kube-proxy #53818

Merged
merged 1 commit into from
Oct 26, 2017
Merged

Update busybox image link to gcr.io for kube-proxy #53818

merged 1 commit into from
Oct 26, 2017

Conversation

MrHohn
Copy link
Member

@MrHohn MrHohn commented Oct 12, 2017 •
edited
Loading

What this PR does / why we need it: Point busybox image to gcr.io.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #NONE

Special notes for your reviewer:
@ixdy @bowei

Release note:

Update busybox image link to gcr.io for kube-proxy.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 12, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 12, 2017
@bowei
Copy link
Member

bowei commented Oct 12, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2017
@bowei
Copy link
Member

bowei commented Oct 12, 2017

/approve no-issue

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2017
@MrHohn
Copy link
Member Author

MrHohn commented Oct 12, 2017

/retest

ixdy
ixdy reviewed Oct 12, 2017
View reviewed changes
cluster/saltbase/salt/kube-proxy/kube-proxy.manifest
@@ -56,7 +56,7 @@ spec:
hostNetwork: true
initContainers:
- name: touch-lock
image: busybox
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gcr.io/google_containers/busybox:1.24 is pretty old (much older than :latest in dockerhub) - why are we using it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to gcr.io/google_containers/busybox:1.27, corresponding to busybox:1.27.

@cblecker
Copy link
Member

/hold
for image update per #53819 (comment)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2017
@MrHohn MrHohn force-pushed the kube-proxy-init-busybox branch from a944ee9 to 83b8155 Compare October 12, 2017 20:35
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2017
@MrHohn
Copy link
Member Author

MrHohn commented Oct 12, 2017

/retest

@cblecker
Copy link
Member

/hold cancel
:)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2017
@bowei
Copy link
Member

bowei commented Oct 24, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2017
@bowei
Copy link
Member

bowei commented Oct 24, 2017

You need to get cherry pick approved.

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, MrHohn

Associated issue requirement bypassed by: bowei

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@MrHohn
Copy link
Member Author

MrHohn commented Oct 24, 2017

/assign @wojtek-t
for cherrypick approval.

@wojtek-t
Copy link
Member

wojtek-t commented Oct 25, 2017 •
edited
Loading

I'm obviously fine with cherrypicking.
Can you please add a release note?

@wojtek-t wojtek-t added this to the v1.7 milestone Oct 25, 2017
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 25, 2017
@k8s-ci-robot k8s-ci-robot removed the release-note-none Denotes a PR that doesn't merit a release note. label Oct 25, 2017
@MrHohn
Copy link
Member Author

MrHohn commented Oct 25, 2017

@wojtek-t Thanks! Release note added to this PR.

@wojtek-t wojtek-t added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed cherrypick-candidate do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Oct 26, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 7a88f3f into kubernetes:release-1.7 Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixdy ixdy ixdy left review comments

Assignees

@bowei bowei

@wojtek-t wojtek-t

@dnardo dnardo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
8 participants
@MrHohn @bowei @cblecker @k8s-github-robot @wojtek-t @ixdy @dnardo @k8s-ci-robot