Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually cherry-pick 4379bbd as it is part of a larger PR #53152

Merged
merged 2 commits into from
Oct 3, 2017
Merged

Manually cherry-pick 4379bbd as it is part of a larger PR #53152

merged 2 commits into from
Oct 3, 2017

Conversation

mbohlool
Copy link
Contributor

@mbohlool mbohlool commented Sep 27, 2017 •
edited
Loading

The commit 4379bbd fixes a bug in openapi spec that resulted in some of the type missing group-version-kind extension. That is specificly serious for the projects that vendor kubernetes in (like minikube). It results in them not having GVKs at all (kubernetes/minikube#1996).

Bugfix: OpenAPI models may not get group-version-kind extension if kubernetes is vendored in another project (e.g. minikube). Kubectl 1.8 needs this extension to work with those projects.

@wojtek-t

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 27, 2017
@k8s-github-robot
Copy link

Adding do-not-merge/release-note-label-needed because the release note process has not been followed.
One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

@k8s-github-robot k8s-github-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 27, 2017
@mbohlool mbohlool mentioned this pull request Sep 27, 2017
Closed
@caesarxuchao
Copy link
Member

Seems related:

FAILED hack/make-rules/../../hack/verify-federation-openapi-spec.sh 130s

@caesarxuchao
Copy link
Member

lgtm after the test fixed.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 28, 2017
@mbohlool
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-bazel

1 similar comment
@mbohlool
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-bazel

@mbohlool
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-bazel

Anybody has any idea why this test is failing? looking at log I only see timeout error, but I see it passes for other PRs.

@wojtek-t
Copy link
Member

wojtek-t commented Oct 2, 2017

@mbohlool - can you please add a user-friendly release-note for this?

@wojtek-t wojtek-t added this to the v1.7 milestone Oct 2, 2017
@mbohlool
Copy link
Contributor Author

mbohlool commented Oct 2, 2017

/test pull-kubernetes-e2e-gce-bazel

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 2, 2017
@mbohlool
Copy link
Contributor Author

mbohlool commented Oct 2, 2017

@wojtek-t Done. Also I am not sure why pull-kubernetes-e2e-gce-bazel is not passing. Do you think it is this PR's fault or it is consistently failing for 1.7 PRs?

@wojtek-t wojtek-t added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed cherrypick-candidate do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Oct 3, 2017
@wojtek-t
Copy link
Member

wojtek-t commented Oct 3, 2017

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbohlool, wojtek-t

Associated issue: 1996

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2017
@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit c33e2b9 into kubernetes:release-1.7 Oct 3, 2017
@k8s-ci-robot
Copy link
Contributor

@mbohlool: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-bazel dba22a4 link /test pull-kubernetes-e2e-gce-bazel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@mbohlool @k8s-github-robot @caesarxuchao @wojtek-t @k8s-ci-robot