Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test initializer name to pass 1.8 validation #52592

Merged
merged 1 commit into from
Sep 19, 2017
Merged

Update test initializer name to pass 1.8 validation #52592

merged 1 commit into from
Sep 19, 2017

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Sep 16, 2017 •
edited
Loading

e2e portion of https://github.com/kubernetes/kubernetes/pull/51283/files#diff-e3afa632328a4a5271f4b8578faa34bd

fixes #52585

fixes upgrade test to work with tightened validation of initializer names in 1.8

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 16, 2017
@k8s-github-robot k8s-github-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 16, 2017
@liggitt liggitt added this to the v1.7 milestone Sep 16, 2017
@k8s-github-robot k8s-github-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 16, 2017
@liggitt liggitt mentioned this pull request Sep 16, 2017
Closed
@caesarxuchao
Copy link
Member

/retest

@caesarxuchao
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, liggitt

Associated issue: 52585

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@caesarxuchao
Copy link
Member

/retest

@liggitt
Copy link
Member Author

liggitt commented Sep 18, 2017

@wojtek-t for release branch approval

@lavalamp
Copy link
Member

@abgworrall I hear you're allowed to approve test fix cherry picks? :)

@abgworrall
Copy link
Contributor

abgworrall commented Sep 18, 2017 •
edited
Loading

I'll be asking for forgiveness from @wojtek-t (and hoping permission will be forthcoming ;) ... but yeah, for super-safe tiny upgrade test fixes, I'll do it.

@abgworrall abgworrall added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 18, 2017
@liggitt liggitt removed cherrypick-candidate do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Sep 18, 2017
@liggitt
Copy link
Member Author

liggitt commented Sep 19, 2017

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@apelisse
Copy link
Member

/retest

1 similar comment
@krzyzacy
Copy link
Member

/retest

@abgworrall abgworrall closed this Sep 19, 2017
@abgworrall abgworrall reopened this Sep 19, 2017
@apelisse
Copy link
Member

Hmm?

@abgworrall
Copy link
Contributor

I tried to cancel my comment, and clicked the grey button - sadly that was close and comment :/

@apelisse
Copy link
Member

Yeah, can we get it manually merged?

@liggitt
Copy link
Member Author

liggitt commented Sep 19, 2017

We should manually merge it. We’ve had three green e2e runs with it.

@apelisse
Copy link
Member

And ... then it fails ;-)

@apelisse
Copy link
Member

/retest

@liggitt
Copy link
Member Author

liggitt commented Sep 19, 2017

the failure was in the unit test job. this PR only touches an e2e test file.

@apelisse
Copy link
Member

Yeah ... OK I'll merge then

@apelisse apelisse merged commit 4c3a6ab into kubernetes:release-1.7 Sep 19, 2017
@liggitt liggitt deleted the initializer-test branch April 22, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ericchiang ericchiang

@caesarxuchao caesarxuchao

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.