Fix proxied request-uri to be valid HTTP requests #52065
Merged
+26
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/S
k8s-github-robot
added
approved
liggitt
added
the
sig/api-machinery
k8s-github-robot
added
release-note
|
Test? |
liggitt
force-pushed
the
proxy-request-uri
branch
from
789ca69
to
4bd692e
Compare
k8s-ci-robot
added
size/L
k8s-github-robot
removed
the
approved
Non-upgrade requests are tested in the e2e proxy tests already. I tested upgrade request proxying manually. Adding upgrade proxy tests would require a websocket test image... can open a follow-up issue for that |
liggitt
force-pushed
the
proxy-request-uri
branch
from
4bd692e
to
e9d8976
Compare
k8s-ci-robot
added
size/S
k8s-github-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@liggitt here's the unit test error: |
liggitt
force-pushed
the
proxy-request-uri
branch
from
e9d8976
to
9648f1c
Compare
|
fixed unit tests to go through the constructor |
k8s-github-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, ncdc Associated issue: 52022 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
wojtek-t
added
the
cherry-pick-approved
k8s-github-robot
pushed a commit
that referenced
this pull request
Sep 8, 2017
…5-upstream-release-1.7-1504806739 Automatic merge from submit-queue Automated cherry pick of #52065 Cherry pick of #52065 on release-1.7. Fixes #52022, introduced in 1.7. Stringifying/re-parsing the URL masked that the path was not constructed with a leading `/` in the first place. This makes upgrade requests proxied to pods/services via the API server proxy subresources be valid HTTP requests ```release-note Fixes an issue with upgrade requests made via pod/service/node proxy subresources sending a non-absolute HTTP request-uri to backends ```
|
Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
k8s-github-robot
pushed a commit
that referenced
this pull request
Sep 23, 2017
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Preserve leading and trailing slashes on proxy subpaths subresource parsing was not populating path parameters correctly (leading and trailing slashes were being stripped) this caused bad locations to be sent to the proxy, causing #52022. the first attempt to fix that (#52065) unconditionally prefixed '/', which broke the redirect case (#52813 #52729) fixes #52813, fixes #52729 needs to be picked to 1.7 and 1.8 ```release-note Restores redirect behavior for proxy subresources ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52022, introduced in 1.7. Stringifying/re-parsing the URL masked that the path was not constructed with a leading
/in the first place.This makes upgrade requests proxied to pods/services via the API server proxy subresources be valid HTTP requests