Skip to content

Automated cherry pick of #49689 upstream release 1.7 #49791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-github-robot merged 1 commit into from
Aug 1, 2017
Merged

Automated cherry pick of #49689 upstream release 1.7 #49791

k8s-github-robot merged 1 commit into from
Aug 1, 2017

Conversation

@divyenpatel
Copy link
Member

@divyenpatel divyenpatel commented Jul 28, 2017

Cherry pick of #49689 on release-1.7

#49689: Reverting deprecation of vCenter port in vSphere Cloud Provider

@luomiao @BaluDontu @tusharnt

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jul 28, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 28, 2017

Hi @divyenpatel. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 28, 2017
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 28, 2017
@k8s-github-robot
Copy link

k8s-github-robot commented Jul 28, 2017

The 'parent' PR of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement. (release-note-experimental must be explicit for cherry-picks)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 28, 2017
@wojtek-t wojtek-t added this to the v1.7 milestone Aug 1, 2017
@wojtek-t wojtek-t added release-note Denotes a PR that will be considered when it comes time to generate release notes. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Aug 1, 2017
@wojtek-t
Copy link
Member

wojtek-t commented Aug 1, 2017

/ok-to-test

/lgtm

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 1, 2017
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2017
@k8s-github-robot
Copy link

k8s-github-robot commented Aug 1, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyenpatel, wojtek-t

Associated issue: 49689

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

k8s-github-robot commented Aug 1, 2017

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit e047a5e into kubernetes:release-1.7 Aug 1, 2017
@divyenpatel divyenpatel deleted the automated-cherry-pick-of-#49689-upstream-release-1.7 branch September 5, 2017 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@freehan freehan

@brendandburns brendandburns

@wojtek-t wojtek-t

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.7

Development

Successfully merging this pull request may close these issues.

6 participants

@divyenpatel @k8s-ci-robot @k8s-github-robot @wojtek-t @freehan @brendandburns