Azure: Allow VNet to be in a separate Resource Group #49725

sylr · 2017-07-27T16:51:45Z

What this PR does / why we need it:

This PR allows Kubernetes in an Azure context to use a VNet which is not in the same Resource Group as Kubernetes.

We need this because currently Azure Cloud Provider driver assumes that it should have a VNet for himself but if there is one thing that should be shared amongst Azure resources it's a VNet cause, well, things might want to talk to each other in a private network, don't you think ?

I guess this should we backported down to 1.6 branch.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):

fixes #49577

Release note:

Azure: Allow VNet to be in a separate Resource Group.

@kubernetes/sig-azure
@kubernetes/sig-azure-pr-reviews

Define a new config VnetResourceGroup in order to be able to use a VNet which is not in the same resource group as kubernetes. Signed-off-by: Sylvain Rabot <[email protected]>

k8s-ci-robot · 2017-07-27T16:51:47Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2017-07-27T16:51:53Z

Hi @sylr. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2017-07-27T16:51:53Z

@sylr: Reiterating the mentions to trigger a notification:
@kubernetes/sig-azure-pr-reviews.

In response to this:

What this PR does / why we need it:

This PR allows Kubernetes in an Azure context to use a VNet which is not in the same Resource Group as Kubernetes.

We need this because currently Azure Cloud Provider driver assumes that it should have a VNet for himself but if there is one thing that should be shared amongst Azure resources it's a VNet cause, well, things might want to talk to each other in a private network, don't you think ?

I guess this should we backported down to 1.6 branch.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):

fixes #49577

Release note:
NONE
@kubernetes/sig-azure
@kubernetes/sig-azure-pr-reviews

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sylr · 2017-07-28T08:01:26Z

/cc @colemickens @karataliu

k8s-ci-robot · 2017-07-28T08:01:32Z

@sylr: GitHub didn't allow me to request PR reviews from the following users: karataliu.

Note that only kubernetes members can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @colemickens @karataliu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sylr · 2017-07-28T08:17:10Z

cncf-cla signed

Add vnetResourceGroup config to /etc/kubernetes/azure.json in an effort to make Kubernetes deployed with a Custom VNet configuration to be able to create internal load balancer services when the VNet is not int the same Resource Group as Kubernetes. For this to work Kubernetes Azure driver must have the following patch: kubernetes/kubernetes#49725 Signed-off-by: Sylvain Rabot <[email protected]>

jdumars · 2017-07-28T16:52:00Z

I'm adding this to the SIG-Azure PR review section. If you could represent it at the next SIG-Azure meeting on 8/9 at 16:00 UTC, we can discuss it.

brendandburns · 2017-08-09T19:08:07Z

/lgtm
/approve
/ok-to-test

brendandburns · 2017-08-09T19:08:37Z

@colemickens fyi

k8s-github-robot · 2017-08-09T19:09:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, sylr

Associated issue: 49577

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~pkg/cloudprovider/providers/azure/OWNERS~~ [brendandburns]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

k8s-github-robot · 2017-08-10T07:53:56Z

/test all [submit-queue is verifying that this PR is safe to merge]

k8s-github-robot · 2017-08-10T08:41:15Z

Automatic merge from submit-queue

djsly · 2017-08-10T21:43:56Z

@jdumars if you could also look for having it in 1.6.9 ... I know I'm asking for a lot but we just upgraded to 1.6. Not sure how fast we will be moving to 1.7.
We are using a separate Vnet as well.

If it can't be done, I would understand.

jdumars · 2017-08-11T02:12:02Z

I'll work with @wojtek-t to see what is possible. @seanknox you feeling adventurous?

jdumars · 2017-08-11T02:12:35Z

BTW thank you @sylr for this work! Welcome to the Azure community.

sylr · 2017-08-11T10:44:05Z

This PR should be cherrypick-candidate for release-1.6 & release-1.7 according to me.

wojtek-t · 2017-08-11T10:52:50Z

@jdumars - please prepare a cherrypick for it, I'm fine with that.

seanknox · 2017-08-14T20:57:59Z

I'm game to cherry pick. Let me know. @jdumars @wojtek-t

jdumars · 2017-08-15T15:23:55Z

@seanknox make it so!

…25-upstream-release-1.6 Automatic merge from submit-queue Automated cherry pick of #49725 Cherry pick of #49725 on release-1.6. #49725: Azure: Allow VNet to be in a separate Resource Group

…25-upstream-release-1.7 Automatic merge from submit-queue Automated cherry pick of #49725 Cherry pick of #49725 on release-1.7. #49725: Azure: Allow VNet to be in a separate Resource Group

dcieslak19973 · 2017-08-23T12:34:43Z

I still am experiencing this problem in 1.7.4

jdumars · 2017-08-23T14:14:01Z

@sylr are you able to help @dcieslak19973 with the implementation details if needed?

sylr · 2017-08-23T16:19:43Z

@dcieslak19973 You need to edit /etc/kubernetes/azure.json on the masters and add the property vnetResourceGroup

dcieslak19973 · 2017-08-23T20:08:51Z

Thanks; I'll check with the acs-engine folks and see if they are doing that when provisioning the cluster.

Add vnetResourceGroup config to /etc/kubernetes/azure.json in an effort to make Kubernetes deployed with a Custom VNet configuration to be able to create internal load balancer services when the VNet is not int the same Resource Group as Kubernetes. For this to work Kubernetes Azure driver must have the following patch: kubernetes/kubernetes#49725 Signed-off-by: Sylvain Rabot <[email protected]>

* Improve Custom VNet support Add vnetResourceGroup config to /etc/kubernetes/azure.json in an effort to make Kubernetes deployed with a Custom VNet configuration to be able to create internal load balancer services when the VNet is not int the same Resource Group as Kubernetes. For this to work Kubernetes Azure driver must have the following patch: kubernetes/kubernetes#49725 Signed-off-by: Sylvain Rabot <[email protected]> * rebase errata

Azure: Allow VNet to be in a separate Resource Group

499d6c3

Define a new config VnetResourceGroup in order to be able to use a VNet which is not in the same resource group as kubernetes. Signed-off-by: Sylvain Rabot <[email protected]>

k8s-ci-robot added sig/azure cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 27, 2017

k8s-github-robot assigned brendandburns Jul 27, 2017

k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jul 27, 2017

k8s-ci-robot requested a review from colemickens July 28, 2017 08:01

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 28, 2017

sylr mentioned this pull request Aug 1, 2017

Improve Custom VNet support Azure/acs-engine#1150

Merged

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 9, 2017

k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2017

k8s-github-robot merged commit 5a25527 into kubernetes:master Aug 10, 2017

ccojocar mentioned this pull request Aug 10, 2017

Add an option for VNet resource group in azure configuration #48426

Closed

This was referenced Aug 15, 2017

Automated cherry pick of #49725 #50700

Merged

Automated cherry pick of #49725 #50701

Merged

enisoc added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 15, 2017

lachie83 mentioned this pull request Aug 17, 2017

Support Kubernetes 1.7.4 Azure/acs-engine#1288

Closed

dcieslak19973 mentioned this pull request Aug 23, 2017

K8s - Internal Load Balancer cannot be provisioned when VNET is outside the Resource Group Azure/acs-engine#1333

Closed

sylr deleted the vnet branch August 24, 2018 11:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Azure: Allow VNet to be in a separate Resource Group #49725

Azure: Allow VNet to be in a separate Resource Group #49725

sylr commented Jul 27, 2017 •

edited by enisoc

Loading

k8s-ci-robot commented Jul 27, 2017

k8s-ci-robot commented Jul 27, 2017

k8s-ci-robot commented Jul 27, 2017

sylr commented Jul 28, 2017

k8s-ci-robot commented Jul 28, 2017

sylr commented Jul 28, 2017

jdumars commented Jul 28, 2017

brendandburns commented Aug 9, 2017

brendandburns commented Aug 9, 2017

k8s-github-robot commented Aug 9, 2017

k8s-github-robot commented Aug 10, 2017

k8s-github-robot commented Aug 10, 2017

djsly commented Aug 10, 2017

jdumars commented Aug 11, 2017

jdumars commented Aug 11, 2017

sylr commented Aug 11, 2017

wojtek-t commented Aug 11, 2017

seanknox commented Aug 14, 2017

jdumars commented Aug 15, 2017

dcieslak19973 commented Aug 23, 2017

jdumars commented Aug 23, 2017

sylr commented Aug 23, 2017

dcieslak19973 commented Aug 23, 2017

Azure: Allow VNet to be in a separate Resource Group #49725

Azure: Allow VNet to be in a separate Resource Group #49725

Conversation

sylr commented Jul 27, 2017 • edited by enisoc Loading

k8s-ci-robot commented Jul 27, 2017

k8s-ci-robot commented Jul 27, 2017

k8s-ci-robot commented Jul 27, 2017

sylr commented Jul 28, 2017

k8s-ci-robot commented Jul 28, 2017

sylr commented Jul 28, 2017

jdumars commented Jul 28, 2017

brendandburns commented Aug 9, 2017

brendandburns commented Aug 9, 2017

k8s-github-robot commented Aug 9, 2017

k8s-github-robot commented Aug 10, 2017

k8s-github-robot commented Aug 10, 2017

djsly commented Aug 10, 2017

jdumars commented Aug 11, 2017

jdumars commented Aug 11, 2017

sylr commented Aug 11, 2017

wojtek-t commented Aug 11, 2017

seanknox commented Aug 14, 2017

jdumars commented Aug 15, 2017

dcieslak19973 commented Aug 23, 2017

jdumars commented Aug 23, 2017

sylr commented Aug 23, 2017

dcieslak19973 commented Aug 23, 2017

sylr commented Jul 27, 2017 •

edited by enisoc

Loading