Fixed glusterfs mount options #49475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Capacity of a slice is the third argument, not the second one. We use append() to fill the slice, so it should be empty at the beginning and with the right capacity.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
size/XS
Member
Author
|
@kubernetes/sig-storage-pr-reviews @humblec |
k8s-ci-robot
added
the
sig/storage
Member
Author
|
/assign @rootfs |
Contributor
|
/lgtm |
k8s-github-robot
added
the
approved
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, rootfs Associated issue requirement bypassed by: rootfs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Contributor
|
/retest |
|
Automatic merge from submit-queue (batch tested with PRs 48911, 49475, 49438, 49362, 49274) |
openshift-merge-robot
added a commit
to openshift/origin
that referenced
this pull request
Jul 27, 2017
Automatic merge from submit-queue Gluster timeout patches There are several upstream patches that shorten gluster timeout when remote gluster servers are unavailable. User gets an error about failed mount in 2 minutes instead of 2 minutes * 2 * nr. of gluster endpoints. kubernetes/kubernetes#42038 kubernetes/kubernetes#49127 kubernetes/kubernetes#48709 kubernetes/kubernetes#49475 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1473587
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capacity of a slice is the third argument, not the second one.
We use append() to fill the slice, so it should be empty at the beginning
and with the right capacity.