Skip to content

Never prevent deletion of resources as part of namespace lifecycle #48733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-github-robot merged 1 commit into from
Jul 17, 2017
Merged

Never prevent deletion of resources as part of namespace lifecycle #48733

k8s-github-robot merged 1 commit into from
Jul 17, 2017
+23 −0

Conversation

@liggitt
Copy link
Member

@liggitt liggitt commented Jul 10, 2017 •
edited by wojtek-t
Loading

Namespace lifecycle should not prevent deletion of resources... its purpose is to prevent creation of resources in a terminating namespace, or create/update of resources in a non-existent namespace.

Fixes #49027

Release note:

Never prevent deletion of resources as part of namespace lifecycle

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 10, 2017
@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 10, 2017
@liggitt
Copy link
Member Author

liggitt commented Jul 10, 2017

cc @kubernetes/sig-api-machinery-bugs
@enj @deads2k @derekwaynecarr

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. kind/bug Categorizes issue or PR as related to a bug. labels Jul 10, 2017
@liggitt liggitt assigned deads2k and unassigned lavalamp Jul 10, 2017
@liggitt liggitt added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jul 10, 2017
@liggitt
Copy link
Member Author

liggitt commented Jul 11, 2017

/retest

1 similar comment
@liggitt
Copy link
Member Author

liggitt commented Jul 11, 2017

/retest

@lavalamp
Copy link
Contributor

lavalamp commented Jul 13, 2017

Can we add a test?

@liggitt liggitt force-pushed the namespace-deletion branch from 41e96dc to 95bf498 Compare July 15, 2017 16:56
@liggitt
Copy link
Member Author

liggitt commented Jul 15, 2017

added a test

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 15, 2017
@ncdc
Copy link
Member

ncdc commented Jul 17, 2017

@liggitt we need an associated issue, correct?

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2017
@k8s-github-robot
Copy link

k8s-github-robot commented Jul 17, 2017

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liggitt, ncdc

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2017
@liggitt
Copy link
Member Author

liggitt commented Jul 17, 2017

added issue

@k8s-github-robot
Copy link

k8s-github-robot commented Jul 17, 2017

Automatic merge from submit-queue (batch tested with PRs 48494, 48733)

@k8s-github-robot k8s-github-robot merged commit e2eefe9 into kubernetes:master Jul 17, 2017
@derekwaynecarr
Copy link
Member

derekwaynecarr commented Jul 17, 2017

good catch; should this be cherry-picked?

@liggitt liggitt deleted the namespace-deletion branch July 18, 2017 01:00
This was referenced Jul 18, 2017
Merged
Merged
@liggitt
Copy link
Member Author

liggitt commented Jul 18, 2017

good catch; should this be cherry-picked?

Yeah, opened picks to 1.6 and 1.7

@wojtek-t wojtek-t added this to the v1.7 milestone Jul 18, 2017
@wojtek-t
Copy link
Member

wojtek-t commented Jul 18, 2017

Cherrypick for 1.7 approved.

@wojtek-t wojtek-t added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 18, 2017
k8s-github-robot pushed a commit that referenced this pull request Jul 18, 2017
Merge pull request #49069 from liggitt/automated-cherry-pick-of-#4873…
6bc0ed8 
…3-upstream-release-1.7

Automatic merge from submit-queue

Automated cherry pick of #48733

Cherry pick of #48733 on release-1.7.

#48733: Never prevent deletion of resources as part of namespace
@k8s-cherrypick-bot
Copy link

k8s-cherrypick-bot commented Jul 18, 2017

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@enisoc enisoc added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 18, 2017
k8s-github-robot pushed a commit that referenced this pull request Jul 20, 2017
Merge pull request #49070 from liggitt/automated-cherry-pick-of-#4873…
00a7f2d 
…3-upstream-release-1.6

Automatic merge from submit-queue

Automated cherry pick of #48733

Cherry pick of #48733 on release-1.6.

#48733: Never prevent deletion of resources as part of namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ncdc ncdc

@mml mml

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.7

Development

Successfully merging this pull request may close these issues.