Skip to content

Automated cherry pick of #48538 #48557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
luxas wants to merge 1 commit into from
Closed

Automated cherry pick of #48538 #48557

luxas wants to merge 1 commit into from

Conversation

@luxas
Copy link
Member

@luxas luxas commented Jul 6, 2017 •
edited by caesarxuchao
Loading

Cherry pick of #48538 on release-1.7.

#48538: Add node-name flag to join phase

Added new flag to `kubeadm join`: --node-name, that lets you specify the name of the Node object that's gonna be created

@GheRivero @luxas
Add node-name flag to join phase
c6096bf 
Allow to specify a node-name instead of relaying in `os.Hostname()`
This is useful where kubelet use the name given by the cloud-provider to
register the node.

Partially fix: kubernetes/kubeadm#64
@k8s-github-robot
Copy link

k8s-github-robot commented Jul 6, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luxas

Associated issue: 48538

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 6, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 6, 2017
@luxas
Copy link
Member Author

luxas commented Jul 6, 2017

FYI @GheRivero, thanks!

PTAL @wojtek-t and @caesarxuchao
We expect one more change related to this one that lets the user specify --node-name on kubeadm init as well

@caesarxuchao caesarxuchao added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jul 6, 2017
@caesarxuchao caesarxuchao added this to the v1.7 milestone Jul 6, 2017
@caesarxuchao
Copy link
Contributor

caesarxuchao commented Jul 7, 2017

Missing lgtm ;)

@luxas luxas assigned jbeda and timothysc and unassigned krousey and lukemarsden Jul 7, 2017
@luxas
Copy link
Member Author

luxas commented Jul 12, 2017

closing in favor of #48791

@luxas luxas closed this Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jbeda jbeda

@timothysc timothysc

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.7

Development

Successfully merging this pull request may close these issues.

9 participants

@luxas @k8s-github-robot @caesarxuchao @jbeda @krousey @timothysc @lukemarsden @k8s-ci-robot @GheRivero