Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apiextensions-apiserver: fix build #48036

Merged
merged 1 commit into from
Jun 26, 2017
Merged

apiextensions-apiserver: fix build #48036

merged 1 commit into from
Jun 26, 2017

Conversation

hongchaodeng
Copy link
Contributor

@hongchaodeng hongchaodeng commented Jun 26, 2017 •
edited by sttts
Loading

Can't build CRD due to this bug. This PR will fix it.

Fix compilation of k8s.io/apiextensions-apiserver

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jun 26, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 26, 2017
@hongchaodeng
Copy link
Contributor Author

@kubernetes/sig-api-machinery-bugs

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. kind/bug Categorizes issue or PR as related to a bug. labels Jun 26, 2017
@hongchaodeng hongchaodeng mentioned this pull request Jun 26, 2017
Merged
@deads2k
Copy link
Contributor

deads2k commented Jun 26, 2017

/lgtm
/release-note-none

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 26, 2017
@hongchaodeng
Copy link
Contributor Author

@deads2k Can you approve this?

@deads2k
Copy link
Contributor

deads2k commented Jun 26, 2017

@deads2k Can you approve this?

sorry, forgot the issue change thing.

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, hongchaodeng

Associated issue requirement bypassed by: deads2k

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2017
@hongchaodeng
Copy link
Contributor Author

@deads2k Thanks!

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 48036, 48022)

@k8s-github-robot k8s-github-robot merged commit 6b97399 into kubernetes:master Jun 26, 2017
@nikhita
Copy link
Member

nikhita commented Jun 27, 2017

Should this be cherry-picked to 1.7 since the godoc for k8s.io/apiextensions-apiserver does not contain the packages pkg/apis/apiextensions and pkg/apis/apiextensions/v1beta1? This PR will fix it.

If agreed, I can create a cherry-pick PR for that.

@deads2k
Copy link
Contributor

deads2k commented Jun 27, 2017

Should this be cherry-picked to 1.7 since the godoc for k8s.io/apiextensions-apiserver does not contain the packages pkg/apis/apiextensions and pkg/apis/apiextensions/v1beta1? This PR will fix it.

It's fine to cherry-pick, but I'm actually not sure if we sync branches. @caesarxuchao

@nikhita the bot is currently of while k8s.io/api is prepped.

@nikhita nikhita mentioned this pull request Oct 4, 2017
Merged
@nikhita
Copy link
Member

nikhita commented Oct 4, 2017 •
edited
Loading

We now have release branches on kubernetes/apiextensions-apiserver (we didn't have this before). The 1.7 release branch on kubernetes/apiextensions-apiserver does not build because of the typo "apiextension-server" here: https://github.com/kubernetes/apiextensions-apiserver/blob/release-1.7/pkg/apis/apiextensions/doc.go#L21.

This can be fixed by cherry-picking this PR. Created a cherry-pick PR: #53426.

cc @wojtek-t @sttts

@wojtek-t wojtek-t added this to the v1.7 milestone Oct 5, 2017
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 5, 2017
@wojtek-t wojtek-t added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 5, 2017
k8s-github-robot pushed a commit that referenced this pull request Oct 5, 2017
Merge pull request #53426 from nikhita/automated-cherry-pick-of-#4803…
38844bb 
…6-upstream-release-1.7

Automatic merge from submit-queue.

Automated cherry pick of #48036

Cherry pick of #48036 on release-1.7.

#48036: apiextensions-apiserver: fix build

```release-notes
Fix compilation of k8s.io/apiextensions-apiserver
```
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@enisoc enisoc

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
8 participants
@hongchaodeng @deads2k @k8s-github-robot @nikhita @k8s-cherrypick-bot @enisoc @wojtek-t @k8s-ci-robot