Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change port on which fluentd exposes its metrics #47402

Merged
merged 1 commit into from
Jun 14, 2017
Merged

Change port on which fluentd exposes its metrics #47402

merged 1 commit into from
Jun 14, 2017

Conversation

crassirostris
Copy link

@crassirostris crassirostris commented Jun 13, 2017 •
edited
Loading

Fix #47397

/cc @Q-Lee @nicksardo

Stackdriver Logging deployment exposes metrics on node port 31337 when enabled.

@crassirostris crassirostris added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Jun 13, 2017
@crassirostris crassirostris added this to the v1.7 milestone Jun 13, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 13, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 13, 2017
@nicksardo
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2017
@crassirostris
Copy link
Author

@k8s-bot pull-kubernetes-unit test this

@crassirostris
Copy link
Author

/retest

@piosz
Copy link
Member

piosz commented Jun 13, 2017

/lgtm
/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crassirostris, nicksardo, piosz

Associated issue: 47397

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@dchen1107
Copy link
Member

Shouldn't we document which ports being reserved by Kube services for the users? Do we have a way to document this in a central place? cc/ @bgrant0607 @chenopis

IMHO, we should at least add a release note for this change, some like reserve port 31337 for fluentd metrics

@nicksardo
Copy link
Contributor

@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

@crassirostris crassirostris removed the release-note-none Denotes a PR that doesn't merit a release note. label Jun 14, 2017
@k8s-github-robot k8s-github-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 14, 2017
@crassirostris
Copy link
Author

@dchen1107 Added a release note, thanks for pointing this out!

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 47302, 47389, 47402, 47468, 47459)

@k8s-github-robot k8s-github-robot merged commit 38fa5dc into kubernetes:master Jun 14, 2017
@dchen1107 dchen1107 mentioned this pull request Jun 15, 2017
Closed
@MrHohn MrHohn mentioned this pull request Jun 19, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicksardo nicksardo Awaiting requested review from nicksardo

@Q-Lee Q-Lee Awaiting requested review from Q-Lee

Assignees

@nicksardo nicksardo

@piosz piosz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
6 participants
@crassirostris @nicksardo @piosz @k8s-github-robot @dchen1107 @k8s-ci-robot