Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS: Perform ELB listener comparison in case-insensitive manner #47391

Merged
merged 1 commit into from
Jun 13, 2017
Merged

AWS: Perform ELB listener comparison in case-insensitive manner #47391

merged 1 commit into from
Jun 13, 2017

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Jun 13, 2017 •
edited by jsafrane
Loading

Fix #47067

AWS: Avoid spurious ELB listener recreation - ignore case when matching protocol

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 13, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 13, 2017
@justinsb justinsb mentioned this pull request Jun 13, 2017
Closed
@jsafrane jsafrane requested review from mikedanese and removed request for mikedanese June 13, 2017 08:57
@jsafrane
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, justinsb

Associated issue: 47067

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@jsafrane
Copy link
Member

I added AWS: prefix to release note.

@justinsb justinsb added this to the v1.7 milestone Jun 13, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 46929, 47391, 47399, 47428, 47274)

@k8s-github-robot k8s-github-robot merged commit d216cfc into kubernetes:master Jun 13, 2017
@justinsb justinsb mentioned this pull request Jun 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jsafrane jsafrane

@zmerlynn zmerlynn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
6 participants
@justinsb @jsafrane @k8s-github-robot @zmerlynn @dchen1107 @k8s-ci-robot