Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promote tls-bootstrap to beta #46799

Merged
merged 1 commit into from
Jun 6, 2017
Merged

promote tls-bootstrap to beta #46799

merged 1 commit into from
Jun 6, 2017

Conversation

mikedanese
Copy link
Member

@mikedanese mikedanese commented Jun 1, 2017 •
edited
Loading

last commit of this PR.

Towards #46999

Promote kubelet tls bootstrap to beta. Add a non-experimental flag to use it and deprecate the old flag.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 1, 2017
@mikedanese mikedanese added this to the v1.7 milestone Jun 1, 2017
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Jun 1, 2017
@fejta
Copy link
Contributor

fejta commented Jun 1, 2017

@k8s-bot pull-kubernetes-federation-e2e-gce test this
ref kubernetes/test-infra#2931

@fejta
Copy link
Contributor

fejta commented Jun 1, 2017

@k8s-bot pull-kubernetes-e2e-kops-aws test this
ref: kubernetes/test-infra#2932

@mikedanese mikedanese added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Jun 1, 2017
@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 1, 2017
@cjcullen
Copy link
Member

cjcullen commented Jun 1, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2017
@liggitt
Copy link
Member

liggitt commented Jun 2, 2017

/lgtm

@liggitt
Copy link
Member

liggitt commented Jun 2, 2017

first two commits approved in #40760

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjcullen, liggitt, mikedanese

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2017
luxas
luxas reviewed Jun 2, 2017
View reviewed changes
plugin/pkg/auth/authorizer/rbac/bootstrappolicy/testdata/controller-roles.yaml Outdated
@@ -74,6 +74,12 @@ items:
verbs:
- update
- apiGroups:
- authorization.k8s.io
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to self: This change is required for kubeadm to work at HEAD

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this gets applied automatically during reconciliation on server start

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liggitt yeah, that was actually what I meant, but I see the double meaning of my comment.
I meant that this change (PR) is needed in the apiserver for kubeadm to work.

Thanks anyway!

@luxas
Copy link
Member

luxas commented Jun 4, 2017

@k8s-bot pull-kubernetes-unit test this

@luxas
Copy link
Member

luxas commented Jun 4, 2017

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@mikedanese
Copy link
Member Author

/retest

saad-ali
saad-ali reviewed Jun 5, 2017
View reviewed changes
cmd/kubelet/app/options/options.go Outdated
fs.StringVar(&f.BootstrapKubeconfig, "experimental-bootstrap-kubeconfig", f.BootstrapKubeconfig, "<Warning: Experimental feature> Path to a kubeconfig file that will be used to get client certificate for kubelet. "+
fs.MarkDeprecated("experimental-bootstrap-kubeconfig", "Use --bootstrap-kubeconfig")
fs.StringVar(&f.BootstrapKubeconfig, "experimental-bootstrap-kubeconfig", f.BootstrapKubeconfig, "deprecated: use --bootstrap-kubeconfig")
fs.StringVar(&f.BootstrapKubeconfig, "bootstrap-kubeconfig", f.BootstrapKubeconfig, "<Warning: Experimental feature> Path to a kubeconfig file that will be used to get client certificate for kubelet. "+
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the string <Warning: Experimental feature> correct here? This is the non-experimental flag right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 5, 2017
@mikedanese mikedanese added lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 5, 2017
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 5, 2017
@luxas
Copy link
Member

luxas commented Jun 5, 2017

I really hope we'll have two flakyless runs now...

@mikedanese
Copy link
Member Author

Kops is basically totally broken right now but the fix is being tested.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 5, 2017 •
edited
Loading

@mikedanese: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-federation-e2e-gce d003607222128cf275725b7718c2e13f8e6594a2 link @k8s-bot pull-kubernetes-federation-e2e-gce test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@luxas
Copy link
Member

luxas commented Jun 5, 2017

During the weekend, federation and unit fought about being the most flaky presubmit. They both did very well... :/

Are we tracking that as a release blocker somewhere?

I saw the fix for kops, +1

@k8s-github-robot k8s-github-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2017
@mikedanese
Copy link
Member Author

/retest

@mikedanese mikedanese added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 46972, 42829, 46799, 46802, 46844)

@k8s-github-robot k8s-github-robot merged commit 8280bd5 into kubernetes:master Jun 6, 2017
@mikedanese mikedanese deleted the gce-3 branch June 6, 2017 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saad-ali saad-ali saad-ali left review comments

@luxas luxas luxas left review comments

@liggitt liggitt liggitt left review comments

Assignees

@liggitt liggitt

@cjcullen cjcullen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
8 participants
@mikedanese @fejta @cjcullen @liggitt @k8s-github-robot @luxas @k8s-ci-robot @saad-ali