Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kube-proxy cleanups #46716

Merged
merged 3 commits into from
Jun 3, 2017
Merged

Kube-proxy cleanups #46716

merged 3 commits into from
Jun 3, 2017

Conversation

thockin
Copy link
Member

@thockin thockin commented May 31, 2017 •
edited
Loading

Add comments.

Clarify flag help.

Rename ExternalTrafficPolicy from "Global" to "Cluster", to not imply federation tie-ins.

Release Note:

When switching from the `service.beta.kubernetes.io/external-traffic` annotation to the new
`externalTrafficPolicy` field, the values chnag as follows:
  * "OnlyLocal" becomes "Local"
  * "Global" becomes "Cluster".

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 31, 2017
@thockin
Copy link
Member Author

thockin commented May 31, 2017

@MrHohn do we have real docs on traffic policy?

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels May 31, 2017
@MrHohn
Copy link
Member

MrHohn commented May 31, 2017

@MrHohn do we have real docs on traffic policy?

No yet, all existing docs is about beta annotations. I will be soon working on updating those docs to reflect the new fields.

@MrHohn
Copy link
Member

MrHohn commented May 31, 2017

LGTM, please run below scripts :)

  • hack/update-federation-openapi-spec.sh
  • hack/update-federation-swagger-spec.sh
  • hack/update-staging-client-go.sh
  • hack/update-swagger-spec.sh

@MrHohn
Copy link
Member

MrHohn commented May 31, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label May 31, 2017
@thockin thockin force-pushed the proxy-comments branch 2 times, most recently from 9e5e6ec to 0838ad4 Compare June 1, 2017 00:47
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2017
@thockin thockin added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Jun 1, 2017
@thockin thockin added this to the v1.7 milestone Jun 1, 2017
@thockin thockin removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jun 1, 2017
@thockin thockin added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2017
@thockin
Copy link
Member Author

thockin commented Jun 1, 2017

re-pushed, self-lgtm

@thockin thockin added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 1, 2017
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2017
@MrHohn
Copy link
Member

MrHohn commented Jun 1, 2017

pull-verify job is still complaining :)

/go/src/k8s.io/kubernetes/docs/api-reference is out of date. Please run hack/update-api-reference-docs.sh

@MrHohn
Copy link
Member

MrHohn commented Jun 2, 2017

@k8s-bot pull-kubernetes-federation-e2e-gce test this

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, thockin

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@fejta
Copy link
Contributor

fejta commented Jun 2, 2017

@k8s-bot pull-kubernetes-federation-e2e-gce test this
ref: #46827

1 similar comment
@shashidharatd
Copy link

@k8s-bot pull-kubernetes-federation-e2e-gce test this
ref: #46827

@shashidharatd
Copy link

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@MrHohn
Copy link
Member

MrHohn commented Jun 2, 2017

This is weird, validation.go is already updated to use "Cluster" instead of "Global" in PR, but from the test failures we could still see "Global" is inused:

E0602 09:57:08.854925       1 servicecontroller.go:518] Failed to execute updates for e2e-tests-federated-service-tgk83/federated-service: Service "federated-service" is invalid: spec.externalTrafficPolicy: Invalid value: "Cluster": ExternalTrafficPolicy must be empty, Global or Local

Triggering test again to verify.

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@shashidharatd
Copy link

@MrHohn, maybe the already deployed k8s clusters are not updated with the change you are mentioning. probably will be fixed after federation k8s clusters are recycled.

@k8s-ci-robot
Copy link
Contributor

@thockin: The following test(s) failed:

Test name Commit Details Rerun command
pull-kubernetes-federation-e2e-gce fc34a9d link @k8s-bot pull-kubernetes-federation-e2e-gce test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MrHohn
Copy link
Member

MrHohn commented Jun 2, 2017

@shashidharatd Thanks, I see the problem now. The changes I mentioned are made in this PR, so they will never be deployed to federation clusters for testing if this PR is not in yet...

@MrHohn
Copy link
Member

MrHohn commented Jun 2, 2017

Wouldn't this model (existing clusters v.s. updated federation server) block all this kind of changes?

@shashidharatd
Copy link

Yes that's a problem we need to address.
For now federation pre-submit will be made merge non-blocking soon and these kind of changes can ignore the test failures.

cc @madhusudancs, @csbell

@madhusudancs
Copy link
Contributor

@MrHohn @shashidharatd federation presubmits won't be made non-blocking for now. We need to figure out what to do for PRs like this. Let me think. I am fine manually merging this PR for now.

@thockin
Copy link
Member Author

thockin commented Jun 3, 2017

OK, I will manually merge this.

@thockin thockin merged commit be987b0 into kubernetes:master Jun 3, 2017
@madhusudancs
Copy link
Contributor

@thockin thanks!

@thockin thockin deleted the proxy-comments branch August 14, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHohn MrHohn MrHohn approved these changes

Assignees

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
7 participants
@thockin @MrHohn @k8s-github-robot @fejta @shashidharatd @k8s-ci-robot @madhusudancs