Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement kubectl get controllerrevisions #46655

Merged
merged 1 commit into from
May 31, 2017
Merged

Implement kubectl get controllerrevisions #46655

merged 1 commit into from
May 31, 2017

Conversation

janetkuo
Copy link
Member

@janetkuo janetkuo commented May 30, 2017 •
edited
Loading

Before:

$ kubectl get controllerrevisions 
error: unknown type &apps.ControllerRevision{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{....}...}

After:

$ kubectl get controllerrevisions 
NAME          CONTROLLER       REVISION   AGE
foo-2312378   DaemonSet/foo    1          2d

Release note:

@kubernetes/sig-apps-pr-reviews @kubernetes/sig-cli-maintainers

@janetkuo janetkuo added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels May 30, 2017
@janetkuo janetkuo added this to the v1.7 milestone May 30, 2017
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 30, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 30, 2017
@smarterclayton
Copy link
Contributor

LGTM

/approve

Merge when green

@janetkuo janetkuo force-pushed the controllerrevision-printer branch from 71068ef to 80af001 Compare May 31, 2017 01:15
@janetkuo
Copy link
Member Author

Updated bazel and gofmt

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janetkuo, smarterclayton

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@janetkuo
Copy link
Member Author

@k8s-bot pull-kubernetes-unit test this
@k8s-bot pull-kubernetes-e2e-kops-aws test this

@janetkuo
Copy link
Member Author

All green, applying tag based on review

@janetkuo janetkuo added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 46661, 46562, 46657, 46655, 46640)

@k8s-github-robot k8s-github-robot merged commit c7e0e50 into kubernetes:master May 31, 2017
@0xmichalis
Copy link
Contributor

@janetkuo can you fill in the release note? Not sure though if this PR warrants one.

@janetkuo
Copy link
Member Author

janetkuo commented Jun 2, 2017

If I leave the release block blank, PR title will be used as release note. The title is enough I think

@0xmichalis
Copy link
Contributor

Didn't know that, OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mengqiy mengqiy

@kow3ns kow3ns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
7 participants
@janetkuo @smarterclayton @k8s-github-robot @0xmichalis @mengqiy @kow3ns @k8s-ci-robot