Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clear init container status annotations when cleared in status #46305

Merged
merged 1 commit into from
May 24, 2017
Merged

clear init container status annotations when cleared in status #46305

merged 1 commit into from
May 24, 2017

Conversation

sjenning
Copy link
Contributor

@sjenning sjenning commented May 23, 2017 •
edited
Loading

When I pod with an init container is terminated due to exceeding its active deadline, the pod status is phase Failed with reason DeadlineExceeded. All container statuses are cleared from the pod status.

With init containers, however, the status is being regenerated from the status annotations. This is causing kubectl to report the pod state as Init:0/1 instead of DeadlineExceeded because the kubectl printer observes a running init container, which in reality is not running.

This PR clears out the init container status annotations when they have been removed from the pod status so they are not regenerated on the apiserver.

xref https://bugzilla.redhat.com/show_bug.cgi?id=1453180

@derekwaynecarr

Fix init container status reporting when active deadline is exceeded.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 23, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels May 23, 2017
@derekwaynecarr
Copy link
Member

@sjenning -- can we have a test?

@derekwaynecarr derekwaynecarr added this to the v1.6 milestone May 23, 2017
@derekwaynecarr derekwaynecarr self-requested a review May 23, 2017 20:51
derekwaynecarr
derekwaynecarr suggested changes May 23, 2017
View reviewed changes
Copy link
Member

@derekwaynecarr derekwaynecarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a test.

@wmengRH
Copy link

wmengRH commented May 23, 2017

bug link should be https://bugzilla.redhat.com/show_bug.cgi?id=1453180

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 23, 2017
@sjenning
Copy link
Contributor Author

@derekwaynecarr test added

@derekwaynecarr
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2017
@derekwaynecarr
Copy link
Member

@smarterclayton -- can you approve?

@smarterclayton
Copy link
Contributor

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, sjenning, smarterclayton

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2017
@sjenning
Copy link
Contributor Author

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@sjenning sjenning mentioned this pull request May 24, 2017
Merged
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 24, 2017 •
edited
Loading

@sjenning: The following test(s) failed:

Test name Commit Details Rerun command
pull-kubernetes-federation-e2e-gce 86bc27b link @k8s-bot pull-kubernetes-federation-e2e-gce test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit b3181ec into kubernetes:master May 24, 2017
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.6" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

1 similar comment
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.6" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@sjenning sjenning deleted the init-container-status branch August 16, 2017 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr derekwaynecarr approved these changes

Assignees

@lavalamp lavalamp

@smarterclayton smarterclayton

@caesarxuchao caesarxuchao

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.
9 participants
@sjenning @derekwaynecarr @wmengRH @smarterclayton @k8s-github-robot @k8s-ci-robot @k8s-cherrypick-bot @lavalamp @caesarxuchao