Skip to content

Node status updater now deletes the node entry in attach updates when node is missing in NodeInformer cache. #46301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-github-robot merged 1 commit into from
Jun 21, 2017
Merged

Node status updater now deletes the node entry in attach updates when node is missing in NodeInformer cache. #46301

k8s-github-robot merged 1 commit into from
Jun 21, 2017

Conversation

@verult
Copy link
Contributor

@verult verult commented May 23, 2017 •
edited
Loading

  • Added RemoveNodeFromAttachUpdates as part of node status updater operations.

What this PR does / why we need it: Fixes issue of unnecessary node status updates when node is deleted.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #42438

Special notes for your reviewer: v1.5 version of the fix addressed by PR #45923. This is necessary because NodeLister did not exist prior to 1.6, thus node status updater requires a slightly different node existence check.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 23, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 23, 2017

Hi @verult. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 23, 2017
@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 23, 2017
@verult
Copy link
Contributor Author

verult commented May 23, 2017

/assign @jingxu97 @saad-ali

@verult verult force-pushed the NodeStatusUpdaterFix-1.5 branch from 29c6c73 to f04f8b2 Compare May 24, 2017 01:17
@verult
Node status updater now deletes the node entry in attach updates when…
256469e 
… node is missing in NodeInformer cache. Fixes kubernetes#42438.

- Added RemoveNodeFromAttachUpdates as part of node status updater operations.
@verult verult force-pushed the NodeStatusUpdaterFix-1.5 branch from f04f8b2 to 256469e Compare May 24, 2017 21:18
@verult
Copy link
Contributor Author

verult commented May 24, 2017

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 24, 2017
@saad-ali
Copy link
Member

saad-ali commented May 24, 2017

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 24, 2017
@saad-ali
Copy link
Member

saad-ali commented May 24, 2017

/lgtm
/approve

CC @mwielgus for approval for 1.5 branch

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2017
@saad-ali saad-ali removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label May 24, 2017
@k8s-github-robot
Copy link

k8s-github-robot commented May 24, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saad-ali, verult

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels May 24, 2017
@verult
Copy link
Contributor Author

verult commented May 25, 2017

@k8s-bot pull-kubernetes-kubemark-e2e-gce test this

@verult
Copy link
Contributor Author

verult commented May 25, 2017 •
edited
Loading

This PR seems to have introduced a bug that causes the previously attached disk to be unattachable once the deleted node restarts. Please put this PR on hold; it's currently under investigation.

UPDATE: This scenario occurs as a rare edge case. Please see PR #45923 for a more detailed explanation.

@verult verult mentioned this pull request May 26, 2017
Closed
@calebamiles calebamiles added this to the v1.7 milestone Jun 2, 2017
@calebamiles calebamiles added this to the v1.7 milestone Jun 2, 2017
@saad-ali saad-ali added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jun 2, 2017
@saad-ali
Copy link
Member

saad-ali commented Jun 2, 2017

Will let @mwielgus remove do-not-merge label

@marun marun modified the milestones: v1.5, v1.7 Jun 8, 2017
@mwielgus mwielgus added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jun 21, 2017
@mwielgus
Copy link
Contributor

mwielgus commented Jun 21, 2017

@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

@k8s-github-robot
Copy link

k8s-github-robot commented Jun 21, 2017

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 058e9d9 into kubernetes:release-1.5 Jun 21, 2017
@k8s-cherrypick-bot
Copy link

k8s-cherrypick-bot commented Jun 21, 2017

Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@verult verult deleted the NodeStatusUpdaterFix-1.5 branch March 24, 2018 01:13
This was referenced Sep 11, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@childsb childsb

@jsafrane jsafrane

@saad-ali saad-ali

@mwielgus mwielgus

@jingxu97 jingxu97

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.5

Development

Successfully merging this pull request may close these issues.