[Federation][kubefed]: Add support for etcd image override #46247
Conversation
k8s-ci-robot
added
sig/federation
cncf-cla: yes
k8s-github-robot
added
size/M
| @@ -207,6 +208,8 @@ func TestInitFederation(t *testing.T) { | |||
| }, | |||
| } | |||
|
|
|||
| etcdImage := "gcr.io/google_containers/etcd:3.0.17" | |||
There was a problem hiding this comment.
Should this have a test? It looks like you added the field to the struct but didn't add a test case.
marun
force-pushed
the
fed-override-etcd-default-image
branch
from
1c47bce
to
d5998fb
Compare
marun
force-pushed
the
fed-override-etcd-default-image
branch
from
d5998fb
to
080d108
Compare
|
@marun: The following test(s) failed:
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csbell, madhusudancs, marun, perotinus
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 46201, 45952, 45427, 46247, 46062) |
This PR adds support for overriding the default etcd image used by
kubefed initby providing an argument to--etcd-image. This is primarily intended to allow consumers like openshift to provide a different default, but as a nice side-effect supports code-free validation of non-default etcd images.Release note:
cc: @kubernetes/sig-federation-pr-reviews