Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kubelet event recording #46246

Merged
merged 1 commit into from
May 23, 2017
Merged

Fix kubelet event recording #46246

merged 1 commit into from
May 23, 2017

Conversation

derekwaynecarr
Copy link
Member

@derekwaynecarr derekwaynecarr commented May 22, 2017 •
edited by enisoc
Loading

What this PR does / why we need it:
There are numerous areas where the kubelet was not properly recording events due to an incorrect type.

To keep this small, I updated all references to RefManager that result in throwing an event to ensure it does a conversion.

Which issue this PR fixes
Fixes #46241
Fixes #44348
Fixes #44652

Special notes for your reviewer:
I updated all references I could find to the existing RefManager in kubelet.

Release note:

Fix kubelet event recording for selected events.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 22, 2017
@derekwaynecarr
Copy link
Member Author

@yujuhong - PTAL.

I tried to keep this as small as possible since this should get cherry-picked.

@derekwaynecarr derekwaynecarr added this to the v1.6 milestone May 22, 2017
@derekwaynecarr derekwaynecarr mentioned this pull request May 22, 2017
Closed
@derekwaynecarr
Copy link
Member Author

derekwaynecarr commented May 22, 2017 •
edited
Loading

i would like a follow-on that moves RefManager itself to the new types, but that grew much larger in scope.

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 22, 2017
@derekwaynecarr
Copy link
Member Author

fyi @ncdc

@yujuhong
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, yujuhong

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@yujuhong
Copy link
Contributor

@derekwaynecarr create a cherrypick PR? :-)

@yujuhong
Copy link
Contributor

@k8s-bot pull-kubernetes-e2e-kops-aws test this

@feiskyer
Copy link
Member

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 23, 2017 •
edited
Loading

@derekwaynecarr: The following test(s) failed:

Test name Commit Details Rerun command
pull-kubernetes-federation-e2e-gce f590697 link @k8s-bot pull-kubernetes-federation-e2e-gce test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 0671a46 into kubernetes:master May 23, 2017
@tacy tacy mentioned this pull request May 26, 2017
Closed
@ravilr
Copy link
Contributor

ravilr commented Jun 26, 2017

@enisoc @yujuhong @derekwaynecarr this is a regression in 1.6. but not cherry-pick'ed yet. Can we please include this in 1.6.7 release?

@yujuhong yujuhong mentioned this pull request Jun 26, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Jun 26, 2017
Merge pull request #48099 from yujuhong/automated-cherry-pick-of-#462…
daf53a8 
…46-upstream-release-1.6

Automatic merge from submit-queue

Automated cherry pick of #46246

Cherry pick of #46246 on release-1.6.

#46246: Fix kubelet event recording
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.6" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

This was referenced Jul 9, 2017
Closed
Closed
@joelittlejohn joelittlejohn mentioned this pull request Oct 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

failed readiness probes not reporting events kubelet failed to report some events 'object does not implement the List interfaces' when logging readiness probe failure
7 participants
@derekwaynecarr @yujuhong @k8s-github-robot @feiskyer @k8s-ci-robot @ravilr @k8s-cherrypick-bot