Add `kubectl config rename-context` #46114

arthur0 · 2017-05-19T16:20:03Z

Add kubectl config rename-context

This command allows renaming a context, instead of editing manually in .kubeconfig

Add `kubectl config rename-context`

k8s-ci-robot · 2017-05-19T16:20:11Z

Hi @arthur0. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mengqiy · 2017-05-20T05:51:37Z

@k8s-bot ok to test

Typo in title.

mengqiy · 2017-05-22T17:25:14Z

s/kubeclt/kubectl

arthur0 · 2017-05-22T19:35:08Z

/release-note-none

mengqiy · 2017-05-23T21:44:21Z

Please run to fix verify:
hack/update-boilerplate.sh
hack/update-generated-docs.sh
hack/update-gofmt.sh

EDIT: nvm. It seems the bot didn't update the comment above.

mengqiy · 2017-05-23T22:10:21Z

@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

mengqiy · 2017-05-23T21:57:56Z

pkg/kubectl/cmd/config/rename_context.go

+		Long:    templates.LongDesc(renameContextLong),
+		Example: templates.Examples(renameContextExample),
+		Run: func(cmd *cobra.Command, args []string) {
+			cmdutil.CheckErr(options.complete(cmd))


According to https://github.com/kubernetes/community/blob/master/contributors/devel/kubectl-conventions.md#command-implementation-conventions, you should capitalize:

Complete

Validate

Run

mengqiy · 2017-05-23T22:12:29Z

pkg/kubectl/cmd/config/rename_context.go

+
+	context, exists := config.Contexts[o.contextName]
+	if !exists {
+		return fmt.Errorf("cannot rename the context %s, it's not in %s", o.contextName, configFile)


nit: use cannot rename the context %q, it's not in %s

mengqiy · 2017-05-23T22:14:05Z

pkg/kubectl/cmd/config/rename_context.go

+
+	_, newExists := config.Contexts[o.newName]
+	if newExists {
+		return fmt.Errorf("cannot rename the context %s, the context %s already exists in %s", o.contextName, o.newName, configFile)


nit: use cannot rename the context %q, the context %q already exists in %s

mengqiy · 2017-05-23T22:17:59Z

pkg/kubectl/cmd/config/rename_context.go

+	"fmt"
+	"io"
+
+	"github.com/spf13/cobra"


Add a new line after this line.

mengqiy · 2017-05-23T22:22:25Z

pkg/kubectl/cmd/config/rename_context_test.go

+	expectedOut    string              //expected out
+}
+
+func TestRenameContext(t *testing.T) {


Can you add more tests to make sure it can handle error cases.

mengqiy · 2017-05-23T23:05:40Z

This is a new command and it deserve a release note.
/release-note

fabianofranz · 2017-05-26T17:55:32Z

@arthur0 Thanks for the PR! Please add a release note to the original PR comment following these instructions.

fabianofranz · 2017-05-26T18:01:51Z

pkg/kubectl/cmd/config/rename_context_test.go

+
+	if len(test.expectedOut) != 0 {
+		if buf.String() != test.expectedOut {
+			t.Errorf("Failded in:%q\n expected out %v\n but got %v", test.description, test.expectedOut, buf.String())


"Failed ..."

fabianofranz · 2017-05-26T18:08:18Z

pkg/kubectl/cmd/config/rename_context.go

+
+		CONTEXT_NAME is the context name that you wish change.
+
+		NEW_NAME is the new name you wish to set.`)


Add a note here in the long desc mentioning something like "in case the context being renamed is the one in use, the 'current-context' field will also be updated to point to the new name". Good job handling that btw.

fabianofranz · 2017-05-26T18:10:03Z

Overall looks good, comments are minor. @deads2k what do you think?

Enables renaming of a context via `kubectl` Fix kubernetes#45131

k8s-ci-robot · 2017-05-26T19:32:10Z

@arthur0: The following test(s) failed:

Test name	Commit	Details	Rerun command
Jenkins verification	`f5da7f2`	link	`@k8s-bot verify test this`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mengqiy · 2017-05-26T20:52:49Z

@k8s-bot pull-kubernetes-unit test this

deads2k · 2017-05-30T11:42:20Z

/lgtm

arthur0 · 2017-05-30T13:36:52Z

/assign @pwittrock

pwittrock · 2017-05-30T16:34:03Z

/approve

k8s-github-robot · 2017-05-30T16:34:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arthur0, deads2k, pwittrock

Needs approval from an approver in each of these OWNERS Files:

~~docs/OWNERS~~ [pwittrock]
~~pkg/kubectl/OWNERS~~ [deads2k,pwittrock]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

k8s-github-robot · 2017-05-30T18:59:05Z

Automatic merge from submit-queue (batch tested with PRs 46489, 46281, 46463, 46114, 43946)

hostirosti · 2017-05-31T09:24:15Z

Thank you @arthur0 for adding this! 👍

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 19, 2017

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 19, 2017

k8s-github-robot assigned fabianofranz and rootfs May 19, 2017

k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels May 19, 2017

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 20, 2017

arthur0 changed the title ~~Add kubeclt config rename-context~~ Add kubeclt config rename-context May 22, 2017

arthur0 force-pushed the rename_context branch 3 times, most recently from 4317b81 to 840a4be Compare May 22, 2017 17:12

k8s-github-robot added the kind/old-docs label May 22, 2017

arthur0 changed the title ~~Add kubeclt config rename-context~~ Add kubectl config rename-context May 22, 2017

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels May 22, 2017

arthur0 changed the title ~~Add kubectl config rename-context~~ [WIP] Add kubectl config rename-context May 22, 2017

arthur0 force-pushed the rename_context branch from 840a4be to 1b12c7e Compare May 23, 2017 20:04

arthur0 changed the title ~~[WIP] Add kubectl config rename-context~~ Add kubectl config rename-context May 23, 2017

mengqiy reviewed May 23, 2017

View reviewed changes

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels May 23, 2017

arthur0 force-pushed the rename_context branch from 1b12c7e to 186923b Compare May 26, 2017 14:24

arthur0 force-pushed the rename_context branch from 186923b to 8309f75 Compare May 26, 2017 16:21

fabianofranz reviewed May 26, 2017

View reviewed changes

arthur0 force-pushed the rename_context branch from 8309f75 to ec166f5 Compare May 26, 2017 18:47

Add kubeclt config rename-context

83fec5b

Enables renaming of a context via `kubectl` Fix kubernetes#45131

arthur0 force-pushed the rename_context branch from ec166f5 to 83fec5b Compare May 26, 2017 18:50

k8s-ci-robot assigned deads2k May 30, 2017

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2017

k8s-ci-robot assigned pwittrock May 30, 2017

k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2017

k8s-github-robot merged commit 1889d65 into kubernetes:master May 30, 2017

arthur0 deleted the rename_context branch May 30, 2017 20:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `kubectl config rename-context` #46114

Add `kubectl config rename-context` #46114

arthur0 commented May 19, 2017 •

edited

Loading

k8s-ci-robot commented May 19, 2017

mengqiy commented May 20, 2017

mengqiy commented May 22, 2017

arthur0 commented May 22, 2017

mengqiy commented May 23, 2017 •

edited

Loading

mengqiy commented May 23, 2017

mengqiy May 23, 2017

arthur0 May 26, 2017

mengqiy May 23, 2017

arthur0 May 26, 2017

mengqiy May 23, 2017

arthur0 May 26, 2017

mengqiy May 23, 2017

arthur0 May 26, 2017

mengqiy May 23, 2017

mengqiy commented May 23, 2017

fabianofranz commented May 26, 2017

fabianofranz May 26, 2017

arthur0 May 26, 2017

fabianofranz May 26, 2017

arthur0 May 26, 2017

fabianofranz commented May 26, 2017

k8s-ci-robot commented May 26, 2017 •

edited

Loading

mengqiy commented May 26, 2017

deads2k commented May 30, 2017

arthur0 commented May 30, 2017

pwittrock commented May 30, 2017

k8s-github-robot commented May 30, 2017

k8s-github-robot commented May 30, 2017

hostirosti commented May 31, 2017


		CONTEXT_NAME is the context name that you wish change.

		NEW_NAME is the new name you wish to set.`)

Add kubectl config rename-context #46114

Add kubectl config rename-context #46114

Conversation

arthur0 commented May 19, 2017 • edited Loading

k8s-ci-robot commented May 19, 2017

mengqiy commented May 20, 2017

mengqiy commented May 22, 2017

arthur0 commented May 22, 2017

mengqiy commented May 23, 2017 • edited Loading

mengqiy commented May 23, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mengqiy commented May 23, 2017

fabianofranz commented May 26, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fabianofranz commented May 26, 2017

k8s-ci-robot commented May 26, 2017 • edited Loading

mengqiy commented May 26, 2017

deads2k commented May 30, 2017

arthur0 commented May 30, 2017

pwittrock commented May 30, 2017

k8s-github-robot commented May 30, 2017

k8s-github-robot commented May 30, 2017

hostirosti commented May 31, 2017

Add `kubectl config rename-context` #46114

Add `kubectl config rename-context` #46114

arthur0 commented May 19, 2017 •

edited

Loading

mengqiy commented May 23, 2017 •

edited

Loading

k8s-ci-robot commented May 26, 2017 •

edited

Loading