Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples: fixed cassandra mirror detection that assumes an FTP site will always be presented #45965

Merged
merged 1 commit into from
May 17, 2017
Merged

Examples: fixed cassandra mirror detection that assumes an FTP site will always be presented #45965

merged 1 commit into from
May 17, 2017

Conversation

tactical-drone
Copy link
Contributor

What this PR does / why we need it:
This fixes regressions in the cassandra example docker image creation scripts

Which issue this PR fixes : #45882

Special notes for your reviewer:
Pound that accept button, it will be fine.

Release note:

Fixed the cassandra docker image cassandra mirror detection logic
bumped cassandra to v3.10, as v3.9 is no longer on the mirrors
bumped ubuntu-slim to v0.9

@tactical-drone
Fixed the cassandra docker image cassandra mirror detection logic
7d3db85 
bumped cassandra to v3.10, as v3.9 is no longer on the mirrors
bumped ubuntu-slim to v0.9
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 17, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @pompomJuice. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 17, 2017
@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 17, 2017
@tactical-drone
Copy link
Contributor Author

I ran it on ubuntu xenial and it works.

@k8s-github-robot k8s-github-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 17, 2017
@resouer
Copy link
Contributor

resouer commented May 17, 2017

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 17, 2017
resouer
resouer approved these changes May 17, 2017
View reviewed changes
Copy link
Contributor

@resouer resouer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code change LGTM

@resouer
Copy link
Contributor

resouer commented May 17, 2017

Next time I think you can use git commit --amend && git push to amend to original PR branch, instead of opening a new one.

@thockin
Copy link
Member

thockin commented May 17, 2017

/approve

@thockin
Copy link
Member

thockin commented May 17, 2017

/lgtm

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pompomJuice, thockin

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 45852, 45965, 45941)

@k8s-github-robot k8s-github-robot merged commit 82a239c into kubernetes:master May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@resouer resouer resouer approved these changes

Assignees

@thockin thockin

@brendandburns brendandburns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tactical-drone @k8s-ci-robot @resouer @thockin @k8s-github-robot @brendandburns